Skip to content

chore(e2e): translation support for core e2e tests - #3555

Merged
openshift-merge-bot[bot] merged 22 commits into
redhat-developer:mainfrom
teknaS47:localization-tests-fr
Oct 22, 2025
Merged

chore(e2e): translation support for core e2e tests#3555
openshift-merge-bot[bot] merged 22 commits into
redhat-developer:mainfrom
teknaS47:localization-tests-fr

Conversation

@teknaS47

Copy link
Copy Markdown
Member

Description

Added translation tests for existing core plugins e2e tests mentioned in the issue below

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@teknaS47

Copy link
Copy Markdown
Member Author

/cc @christoph-jerolimov

@github-actions

Copy link
Copy Markdown
Contributor

@invincibleJai

Copy link
Copy Markdown
Member

/retest

@invincibleJai

Copy link
Copy Markdown
Member

/cherrypick release-1.8

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@invincibleJai: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@HusneShabbir

Copy link
Copy Markdown
Member

/retest

@github-actions

Copy link
Copy Markdown
Contributor

@teknaS47

Copy link
Copy Markdown
Member Author

/retest

@github-actions

Copy link
Copy Markdown
Contributor

@teknaS47

Copy link
Copy Markdown
Member Author

/retest

@github-actions

Copy link
Copy Markdown
Contributor

Comment thread translations/test/missing-fr-translations.json
@teknaS47

Copy link
Copy Markdown
Member Author

/retest

@github-actions

Copy link
Copy Markdown
Contributor

@ciiay

ciiay commented Oct 21, 2025

Copy link
Copy Markdown
Member

/retest

2 similar comments
@ciiay

ciiay commented Oct 21, 2025

Copy link
Copy Markdown
Member

/retest

@ciiay

ciiay commented Oct 21, 2025

Copy link
Copy Markdown
Member

/retest

its-mitesh-kumar and others added 2 commits October 22, 2025 07:46
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@rostalan

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Oct 22, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christoph-jerolimov, HusneShabbir, invincibleJai, jmagak, karthikjeeyar, rostalan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [christoph-jerolimov,invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 659c572 into redhat-developer:main Oct 22, 2025
14 checks passed
@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@invincibleJai: #3555 failed to apply on top of branch "release-1.8":

Applying: chore(e2e): translation support for core e2e tests
Using index info to reconstruct a base tree...
M	e2e-tests/playwright/e2e/extensions.spec.ts
Falling back to patching base and 3-way merge...
Removing e2e-tests/playwright/e2e/localization/locale-test.spec.ts
Auto-merging e2e-tests/playwright/e2e/extensions.spec.ts
CONFLICT (content): Merge conflict in e2e-tests/playwright/e2e/extensions.spec.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 chore(e2e): translation support for core e2e tests

Details

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chadcrum pushed a commit to chadcrum/rhdh that referenced this pull request Oct 23, 2025
…3555)

* chore(e2e): translation support for core e2e tests

* added missing translations, removed homepage translations

* adding test suite for running french translations

* minor changes

* rebase and fix

* removing custom plugins

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>

* fix

* fix

---------

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Co-authored-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
kim-tsao pushed a commit to kim-tsao/rhdh that referenced this pull request Feb 9, 2026
…3555)

* chore(e2e): translation support for core e2e tests

* added missing translations, removed homepage translations

* adding test suite for running french translations

* minor changes

* rebase and fix

* removing custom plugins

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>

* fix

* fix

---------

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Co-authored-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
kim-tsao added a commit that referenced this pull request Feb 11, 2026
* chore(e2e): translation support for core e2e tests

* added missing translations, removed homepage translations

* adding test suite for running french translations

* minor changes

* rebase and fix

* removing custom plugins



* fix

* fix

---------

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Co-authored-by: Sanket Saikia <sanketsaikia13@gmail.com>
Co-authored-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@rhdh-qodo-merge rhdh-qodo-merge Bot mentioned this pull request Apr 22, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.