Skip to content

chore(e2e): skip two bulk import test cases for further investigation - #3665

Merged
gustavolira merged 2 commits into
redhat-developer:mainfrom
josephca:RHDHBUGS-2230
Nov 7, 2025
Merged

chore(e2e): skip two bulk import test cases for further investigation#3665
gustavolira merged 2 commits into
redhat-developer:mainfrom
josephca:RHDHBUGS-2230

Conversation

@josephca

@josephca josephca commented Nov 7, 2025

Copy link
Copy Markdown
Member

Description

Skip two bulk import test cases for further investigation

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci

openshift-ci Bot commented Nov 7, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign psrna for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhdh-qodo-merge

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

RHDHBUGS-2230 - Partially compliant

Compliant requirements:

  • Prevent pipeline instability caused by these failures while investigation is ongoing.
  • Provide references/evidence to the failing tests and context.
  • Plan for follow-up fix (tracking).

Non-compliant requirements:

  • Investigate intermittent/consistent failures in two bulk import E2E tests in ephemeral environment.

Requires further human verification:

  • Verify that failures are indeed related to ephemeral environment conditions (e.g., data/state, auth, timing).
  • Confirm with CI runs that skipping these tests stabilizes the pipeline.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🔒 No security concerns identified
⚡ Recommended focus areas for review

Test Coverage Gap

Skipping two tests creates a blind spot around bulk import flows; ensure equivalent coverage remains or add temporary smoke checks to detect regressions.

// TODO: https://issues.redhat.com/browse/RHDHBUGS-2230
// Select two repos: one with an existing catalog.yaml file and another without it
test.fixme("Add a Repository from the Repository Tab and Confirm its Preview", async () => {
  await uiHelper.openSidebar("Bulk import");
  await uiHelper.clickButton("Import");
  await uiHelper.searchInputPlaceholder(catalogRepoDetails.name);
Long-term Skip

Using test.fixme without an expiry or conditional skip risks becoming permanent; consider adding a comment with owner and unskip criteria or a conditional skip tied to env.

// TODO: https://issues.redhat.com/browse/RHDHBUGS-2230
test.fixme("Verify existing repo from app-config is displayed in bulk import Added repositories", async () => {
  await uiHelper.openSidebar("Bulk import");
  await common.waitForLoad();
  await bulkimport.filterAddedRepo(existingRepoFromAppConfig);
  await uiHelper.verifyRowInTableByUniqueText(existingRepoFromAppConfig, [
📄 References
  1. No matching references available

@rhdh-qodo-merge rhdh-qodo-merge Bot added the Tests label Nov 7, 2025
@rhdh-qodo-merge

rhdh-qodo-merge Bot commented Nov 7, 2025

Copy link
Copy Markdown

PR Type

Tests


Description

  • Skip two bulk import test cases using test.fixme() for further investigation

  • Add TODO comments referencing RHDHBUGS-2230 issue for tracking

  • Tests remain in codebase but are marked as pending resolution


File Walkthrough

Relevant files
Tests
bulk-import.spec.ts
Mark two bulk import tests as pending                                       

e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts

  • Changed first test from test() to test.fixme() for "Add a Repository
    from the Repository Tab and Confirm its Preview"
  • Changed second test from test() to test.fixme() for "Verify existing
    repo from app-config is displayed in bulk import Added repositories"
  • Added TODO comments with [RHDHBUGS-2230](https://issues.redhat.com//browse/RHDHBUGS-2230) issue link above both skipped
    tests
+4/-2     

@rhdh-qodo-merge

rhdh-qodo-merge Bot commented Nov 7, 2025

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@github-actions

github-actions Bot commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

@gustavolira
gustavolira merged commit 8d2022f into redhat-developer:main Nov 7, 2025
10 of 11 checks passed
@josephca
josephca deleted the RHDHBUGS-2230 branch November 7, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants