Skip to content

fix: auto-approve workflow test - #3683

Merged
openshift-merge-bot[bot] merged 26 commits into
redhat-developer:mainfrom
polasudo:fix/auto-approve-bot
Nov 14, 2025
Merged

fix: auto-approve workflow test#3683
openshift-merge-bot[bot] merged 26 commits into
redhat-developer:mainfrom
polasudo:fix/auto-approve-bot

Conversation

@polasudo

@polasudo polasudo commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

Expected behavior:

  • Workflow should run and check eligibility
  • Should skip auto-approval (since it's not rhdh-bot)
  • Should log the eligibility check results

The gh CLI commands were failing because the repository wasn't checked out.
Added actions/checkout@v4 step to ensure git context is available.
Using pull_request_target instead of pull_request allows the workflow
to run with write permissions even for PRs from forks or bot accounts.
This is necessary for adding labels and approving PRs.
@polasudo
polasudo marked this pull request as draft November 13, 2025 14:37
@polasudo
polasudo marked this pull request as ready for review November 13, 2025 14:37
- Remove all testing code (push triggers, test PR numbers, debug logging)
- Simplify workflow to only run on pull_request_target events
- Only run for rhdh-bot PRs
- Keep fix/auto-approve-bot pattern for final testing before merge
- Ready for production deployment
- Remove temporary polasudo testing allowance
- Remove fix/auto-approve-bot test pattern
- Clean, production-ready workflow for rhdh-bot PRs
- Ready to merge and deploy
@polasudo polasudo changed the title test Auto-approve workflow test - DO NOT MERGE fix auto-approve workflow test Nov 13, 2025
@polasudo polasudo changed the title fix auto-approve workflow test fix: auto-approve workflow test Nov 13, 2025
Comment thread .github/workflows/auto-approve-bot-prs.yaml Outdated
@nickboldt
nickboldt requested a review from Zaperex November 14, 2025 14:36
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@Zaperex

Zaperex commented Nov 14, 2025

Copy link
Copy Markdown
Member

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Nov 14, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt, Zaperex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit f9bf0a8 into redhat-developer:main Nov 14, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants