Skip to content

feat: catalog index consumption in install-dynamic-plugins.py to extract and consume catalog index - #3737

Merged
rm3l merged 30 commits into
redhat-developer:mainfrom
Fortune-Ndlovu:RHIDP-9761-catalog-index-extraction
Dec 2, 2025
Merged

feat: catalog index consumption in install-dynamic-plugins.py to extract and consume catalog index#3737
rm3l merged 30 commits into
redhat-developer:mainfrom
Fortune-Ndlovu:RHIDP-9761-catalog-index-extraction

Conversation

@Fortune-Ndlovu

@Fortune-Ndlovu Fortune-Ndlovu commented Nov 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

catalog index consumption in install-dynamic-plugins.py to extract and use dynamic-plugins.default.yaml from an OCI artifact instead of the embedded file.

Assisted-by: Cursor
Signed-off-by: Fortune Ndlovu fndlovu@redhat.com

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci
openshift-ci Bot requested review from kim-tsao and rm3l November 23, 2025 03:19
@Fortune-Ndlovu
Fortune-Ndlovu force-pushed the RHIDP-9761-catalog-index-extraction branch from 79511b2 to 7463a90 Compare November 23, 2025 03:37
@Fortune-Ndlovu
Fortune-Ndlovu force-pushed the RHIDP-9761-catalog-index-extraction branch from 7463a90 to 51bb708 Compare November 23, 2025 03:53
@github-actions

github-actions Bot commented Nov 23, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@Fortune-Ndlovu
feat: add catalog index OCI artifact support to install-dynamic-plugi…
39e9fd5 
…ns.py

Enable install-dynamic-plugins.py to consume plugin catalog index as an OCI artifact.
When CATALOG_INDEX_IMAGE is set, the script uses skopeo to pull the catalog index image,
extracts its layers to a temporary directory, and reads dynamic-plugins.default.yaml from
the artifact. This file is prepended to the includes list, replacing the embedded default
file to avoid duplicates. The implementation supports tar auto-detection (r:*) for different
compression formats, fixes an OCI plugin directory creation bug, and ensures cleanup of
temporary files after processing. Fully backwards compatible when CATALOG_INDEX_IMAGE is not set.
@Fortune-Ndlovu
Fortune-Ndlovu force-pushed the RHIDP-9761-catalog-index-extraction branch from 51bb708 to 39e9fd5 Compare November 23, 2025 06:25
@github-actions

github-actions Bot commented Nov 23, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@github-actions

github-actions Bot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

rm3l
rm3l reviewed Nov 24, 2025
View reviewed changes
Comment thread docker/install-dynamic-plugins.py
@Fortune-Ndlovu
Add a defensive file existence check in the extract_catalog_index()
dd2917e 
function to handle cases where layer files referenced in the OCI manifest are
missing from the downloaded image. Instead of failing with an unhandled exception,
the function should print a warning and continues processing other layers. Add unit tests to validate the catalog index extraction features including
success cases, missing file handling, and large file skipping. Lastly add minimal documentation

Signed-off-by: Fortune Ndlovu <fndlovu@redhat.com>
@Fortune-Ndlovu
Update documentation wording
c0801c6 
Signed-off-by: Fortune Ndlovu <fndlovu@redhat.com>
@Fortune-Ndlovu
fix: remove trailing whitespace changes from catalog index feature
bddef47 
Signed-off-by: Fortune Ndlovu <fndlovu@redhat.com>
@Fortune-Ndlovu
Restore test file from upstream/main to preserve original trailing wh…
ff65e78 
…itespace,while keeping only the functional additions for catalog index testing

Signed-off-by: Fortune Ndlovu <fndlovu@redhat.com>
@github-actions

github-actions Bot commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@github-actions

github-actions Bot commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@Fortune-Ndlovu

Fortune-Ndlovu commented Dec 1, 2025

Copy link
Copy Markdown
Member Author

cc/ @rm3l for final review please

rm3l
rm3l reviewed Dec 1, 2025
View reviewed changes
Comment thread docker/install-dynamic-plugins.py Outdated
Comment thread docker/install-dynamic-plugins.py Outdated
Comment thread docker/install-dynamic-plugins.py Outdated
Comment thread docker/install-dynamic-plugins.py Outdated
Comment thread docker/install-dynamic-plugins.py Outdated
Comment thread docker/install-dynamic-plugins.py Outdated
@Fortune-Ndlovu
resolve SonarQube issue: Change the parameter name from dynamicPlugin…
54801aa 
…sRoot to dynamic_plugins_root in the cleanup function to follow Python's PEP 8 snake_case naming convention
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

@Fortune-Ndlovu
Fortune-Ndlovu force-pushed the RHIDP-9761-catalog-index-extraction branch from df3acfc to ce9f4af Compare December 1, 2025 17:32
@Fortune-Ndlovu
Fortune-Ndlovu force-pushed the RHIDP-9761-catalog-index-extraction branch from ce9f4af to df3acfc Compare December 1, 2025 17:38
@sonarqubecloud

sonarqubecloud Bot commented Dec 1, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

The image is available at:

rm3l
rm3l approved these changes Dec 2, 2025
View reviewed changes

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Dec 2, 2025
@openshift-ci

openshift-ci Bot commented Dec 2, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt, rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rm3l
rm3l merged commit a18bbc9 into redhat-developer:main Dec 2, 2025
17 checks passed
@rhdh-qodo-merge rhdh-qodo-merge Bot mentioned this pull request Apr 21, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickboldt nickboldt nickboldt approved these changes
@rm3l rm3l rm3l approved these changes
@kim-tsao kim-tsao Awaiting requested review from kim-tsao

Assignees

@rm3l rm3l

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fortune-Ndlovu @nickboldt @rm3l