feat(ocm): Install and configure the ocm plugin - #38
Merged
Conversation
SamoKopecky
force-pushed
the
ocm
branch
3 times, most recently
from
February 22, 2023 10:08
005c34c to
f3ad9b9
Compare
christophe-f
approved these changes
Feb 22, 2023
Comment on lines
23
to
24
Contributor
There was a problem hiding this comment.
Can we add this in the app-config.yaml?
Author
There was a problem hiding this comment.
I don't think we can put this into the app-config.yaml at this time, this would require some additional changes to the source code. However we can talk about this more and maybe implement it in the future.
Contributor
There was a problem hiding this comment.
no problem. I just wanted to keep track here.
Will merge later today. Need the environment up for a recording.
added 2 commits
February 22, 2023 18:02
Signed-off-by: SamoKopecky <skopecky@redhat.com>
Signed-off-by: SamoKopecky <skopecky@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it
Install the OCM plugin and all of the fronted components. Discovered clusters are converted to catalog entities with kind
resource.Which issue(s) does this PR fix
Fixes #7
PR acceptance criteria
How to test changes / Special notes to the reviewer
The secret
moc_infra_tokenis located in vault inmoc/smaug/service-catalog/k8s-plugin-tokens. The added external secret will create a secret in thejanus-idpnamespace and will get consumed.