chore(ci): fix error handling & add timeout - #3835
Merged
openshift-merge-bot[bot] merged 6 commits intoDec 11, 2025
Merged
Conversation
Sometimes the log collection is stuck
Member
|
/approve |
|
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gustavolira The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
The image is available at: |
Member
Author
|
/test e2e-ocp-helm |
Member
Author
openshift-merge-bot
Bot
merged commit Dec 11, 2025
8db5ff1
into
redhat-developer:main
20 checks passed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR fixes CI/CD pipeline error handling issues that were causing:
kubectl logscommands to hang indefinitely when pods were unresponsiveSee this log, where the issues happened: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/redhat-developer_rhdh/3830/pull-ci-redhat-developer-rhdh-main-e2e-ocp-helm/1998787878628364288/artifacts/e2e-ocp-helm/redhat-developer-rhdh-ocp-helm/build-log.txt
Root Cause Analysis
The CI script was configured with
set -o errexitandtrap cleanup EXIT INT ERR. When combined withpipefail(enabled byconfigure_external_postgres_db()), this caused:yarn playwright test | teewould fail the entire script when tests failed (due topipefail)ERRandEXITtraps fired on failureskubectl logshad no timeout, causing 40+ minute hangs when pods were stuckChanges
openshift-ci-tests.shEXITonly (removesINTandERR)EXITtrap fires exactly once on any termination, preventing duplicate cleanuputils.shretrieve_pod_logs(): Added 30-second timeout tokubectl logscommands to prevent hangingconfigure_external_postgres_db(): Removed unnecessaryset -euo pipefailthat was leaking globallyExpected Behavior
kubectl logshangsWhich issue(s) does this PR fix
PR acceptance criteria
How to test changes / Special notes to the reviewer