Skip to content

chore: re-enable tests in config-map.spec.ts - #3851

Closed
christoph-jerolimov wants to merge 1 commit into
redhat-developer:mainfrom
christoph-jerolimov:reenable-config-map
Closed

chore: re-enable tests in config-map.spec.ts#3851
christoph-jerolimov wants to merge 1 commit into
redhat-developer:mainfrom
christoph-jerolimov:reenable-config-map

Conversation

@christoph-jerolimov

Copy link
Copy Markdown
Member

This is a follow-up PR on #3839 to re-enable tests.

This e2e-test should pass at least 3 (more?) times with 100% success ratio to get merged.

/assign @redhat-developer/rhdh-cope
/hold

@openshift-ci

openshift-ci Bot commented Dec 12, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gustavolira for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhdh-qodo-merge

Copy link
Copy Markdown

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🔒 No security concerns identified
⚡ Recommended focus areas for review

Flakiness Risk

Re-enabling the whole describe block may surface previously flaky behavior; ensure related setup/teardown and environment preconditions are stable and not time/order dependent.

test.describe("Change app-config at e2e test runtime", () => {
  test.beforeAll(async () => {
📄 References
  1. No matching references available

@rhdh-qodo-merge

Copy link
Copy Markdown

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Type

Tests


Description

  • Re-enable config-map e2e tests by removing skip decorator

  • Tests were previously skipped and now restored for execution


File Walkthrough

Relevant files
Tests
config-map.spec.ts
Remove skip decorator from test suite                                       

e2e-tests/playwright/e2e/configuration-test/config-map.spec.ts

  • Removed skip modifier from test.describe to re-enable the test suite
  • Test suite "Change app-config at e2e test runtime" is now active
+1/-1     

@rhdh-qodo-merge

Copy link
Copy Markdown

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Code Suggestions ✨

No code suggestions found for the PR.

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

@zdrapela

Copy link
Copy Markdown
Member

Incorporated in #3830
/close

@openshift-ci openshift-ci Bot closed this Dec 16, 2025
@openshift-ci

openshift-ci Bot commented Dec 16, 2025

Copy link
Copy Markdown

@zdrapela: Closed this PR.

Details

In response to this:

Incorporated in #3830
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@christoph-jerolimov
christoph-jerolimov deleted the reenable-config-map branch December 17, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants