Skip to content

chore: re-enable tests in verify-tls-config-with-external-azure-db.spec.ts - #3856

Closed
christoph-jerolimov wants to merge 1 commit into
redhat-developer:mainfrom
christoph-jerolimov:reenable-verify-tls-config-with-external-azure-db
Closed

chore: re-enable tests in verify-tls-config-with-external-azure-db.spec.ts#3856
christoph-jerolimov wants to merge 1 commit into
redhat-developer:mainfrom
christoph-jerolimov:reenable-verify-tls-config-with-external-azure-db

Conversation

@christoph-jerolimov

Copy link
Copy Markdown
Member

This is a follow-up PR on #3839 to re-enable tests.

This e2e-test should pass at least 3 (more?) times with 100% success ratio to get merged.

/assign @redhat-developer/rhdh-cope
/hold

@openshift-ci

openshift-ci Bot commented Dec 12, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign psrna for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhdh-qodo-merge

Copy link
Copy Markdown

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🔒 No security concerns identified
⚡ Recommended focus areas for review

Flakiness Risk

Re-enabling the suite with .serial can increase runtime and hides concurrency issues; ensure any timing-dependent steps or external Azure DB dependencies are stable and that proper waits/retries/logging are in place to diagnose intermittent failures.

.serial("Verify TLS configuration with Azure Database for PostgreSQL health check", () => {
const namespace = process.env.NAME_SPACE_RUNTIME || "showcase-runtime";
const job: string = process.env.JOB_NAME || "";
let deploymentName = process.env.RELEASE_NAME + "-developer-hub";
if (job.includes("operator")) {
  deploymentName = "backstage-" + process.env.RELEASE_NAME;
Env Var Assumptions

The test depends on RELEASE_NAME, JOB_NAME, and NAME_SPACE_RUNTIME; consider validating or defaulting these to avoid accidental false negatives when env vars are missing or malformed.

const namespace = process.env.NAME_SPACE_RUNTIME || "showcase-runtime";
const job: string = process.env.JOB_NAME || "";
let deploymentName = process.env.RELEASE_NAME + "-developer-hub";
if (job.includes("operator")) {
  deploymentName = "backstage-" + process.env.RELEASE_NAME;
📄 References
  1. No matching references available

@rhdh-qodo-merge

Copy link
Copy Markdown

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Type

Tests


Description

  • Re-enable previously skipped e2e test for Azure Database TLS configuration

  • Change test execution mode from skip to serial for proper test sequencing


File Walkthrough

Relevant files
Tests
verify-tls-config-with-external-azure-db.spec.ts
Re-enable test with serial execution mode                               

e2e-tests/playwright/e2e/external-database/verify-tls-config-with-external-azure-db.spec.ts

  • Changed test.describe.skip() to test.describe.serial() to re-enable
    the test
  • Allows test to run sequentially instead of being skipped
  • Maintains existing test structure and configuration
+1/-1     

@rhdh-qodo-merge

Copy link
Copy Markdown

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Code Suggestions ✨

No code suggestions found for the PR.

@github-actions

Copy link
Copy Markdown
Contributor

@christoph-jerolimov
christoph-jerolimov force-pushed the reenable-verify-tls-config-with-external-azure-db branch from 0e158b9 to b41046f Compare December 12, 2025 20:28
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

@christoph-jerolimov

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@rhdh-qodo-merge

Copy link
Copy Markdown

You are above your monthly Qodo Merge usage quota. If you are a paying user, please link your GitHub/GitLab/Bitbucket account with your qodo account here to claim your seat. To allow usage organization-wide without linking, please reach to Qodo.

@christoph-jerolimov

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@rhdh-qodo-merge

Copy link
Copy Markdown

You are above your monthly Qodo Merge usage quota. If you are a paying user, please link your GitHub/GitLab/Bitbucket account with your qodo account here to claim your seat. To allow usage organization-wide without linking, please reach to Qodo.

@openshift-ci

openshift-ci Bot commented Dec 15, 2025

Copy link
Copy Markdown

@christoph-jerolimov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm b41046f link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zdrapela

Copy link
Copy Markdown
Member

Incorporated in #3830
/close

@openshift-ci openshift-ci Bot closed this Dec 16, 2025
@openshift-ci

openshift-ci Bot commented Dec 16, 2025

Copy link
Copy Markdown

@zdrapela: Closed this PR.

Details

In response to this:

Incorporated in #3830
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@christoph-jerolimov
christoph-jerolimov deleted the reenable-verify-tls-config-with-external-azure-db branch December 17, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants