refactor(ci): clean install-methods and implement lib/config.sh - #4134
Conversation
- Replace custom polling loops with common::poll_until in operator.sh - Extract debug info collection to _operator_debug_info helper - Remove unused install-methods/helm.sh (empty file) - Reduce deploy_rhdh_operator from ~80 to ~50 lines Closes: RHIDP-11013 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
gustavolira
changed the title
- Create lib/config.sh with 5 configuration functions: - config::create_app_config_map - config::select_config_map_file - config::create_dynamic_plugins_config - config::create_conditional_policies_operator - config::prepare_operator_app_config - Migrate all callers to use config:: prefix (no backward compatibility) - Remove config function shims from utils.sh - Migrate sed_inplace to common::sed_inplace - Update lib/README.md documentation Closes: RHIDP-11712 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
7c02b5e to
b05d2a1
Compare
|
/test ? |
|
/test e2e-ocp-helm-nightly |
|
The image is available at: |
Fix command not found error by migrating missed function calls: - wait_for_job_completion → k8s_wait::job - wait_for_deployment → k8s_wait::deployment (2 calls) - wait_for_endpoint → k8s_wait::endpoint (2 calls) These were missed in PR redhat-developer#4133 when k8s-wait shims were removed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
🚫 Image Push Skipped. The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image) |
|
|
/test e2e-ocp-helm-nightly |
1 participant
Summary
Refactor install-methods, implement lib/config.sh module, and fix k8s-wait migration issues.
RHIDP-11013: Clean install-methods
install-methods/operator.shcommon::poll_untilinstall-methods/helm.shRHIDP-11712: Implement lib/config.sh
lib/config.shutils.shjobs/ocp-operator.shcluster/eks/eks-operator-deployment.shcluster/aks/aks-operator-deployment.shcluster/gke/gke-operator-deployment.shlib/README.mdBug Fix: k8s-wait migration
Fixes
command not founderrors from PR #4133 by migrating missed function calls:wait_for_job_completion→k8s_wait::jobwait_for_deployment→k8s_wait::deployment(2 calls)wait_for_endpoint→k8s_wait::endpoint(2 calls)New functions in lib/config.sh:
config::create_app_config_mapconfig::select_config_map_fileconfig::create_dynamic_plugins_configconfig::create_conditional_policies_operatorconfig::prepare_operator_app_configTest plan
bash -nsyntax check passed for all filesshellcheck --severity=warningpassed (no warnings)yarn prettier:fixpassedCloses: RHIDP-11013, RHIDP-11712
🤖 Generated with Claude Code