fix(i18n): fix translation override issue by ciiay · Pull Request #4165 · redhat-developer/rhdh

ciiay · 2026-02-03T02:08:23Z

Description

Document translation priority (app-config → JSON → TS → ref) and that rhdh JSON overrides backstage.
Fix Administration menu: translate sidebar section label and config-driven admin item by mapping app-config textKey to titleKey.
Add textKey to MenuItemConfig and set titleKey from it when building menu items.
Remove hardcoded Scaffolder page title and dead app.scaffolder.title from rhdh ref/locales.
Add rhdh-fr.json, rhdh-it.json, rhdh-ja.json under translations/.
Trim scaffolder locale files (e.g. French overrides only) for consistency.

Which issue(s) does this PR fix

Fixes RHDHBUGS-2564
Fixes RHDHBUGS-2584

PR acceptance criteria

Please make sure that the following steps are complete:

GitHub Actions are completed and successful
Unit Tests are updated and passing
E2E Tests are updated and passing
Documentation is updated if necessary (requirement for new features)
Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Before:

After:

Verified on a cluster:

github-actions · 2026-02-03T02:48:41Z

The image is available at:

karthikjeeyar

Verified the PR image

/approve
/lgtm

karthikjeeyar · 2026-02-03T04:11:03Z

/retest

rohitkrai03

/approved

christoph-jerolimov · 2026-02-03T05:59:42Z

/cherry-pick release-1.9

openshift-cherrypick-robot · 2026-02-03T05:59:46Z

@christoph-jerolimov: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

christoph-jerolimov · 2026-02-03T06:00:14Z

/retest

invincibleJai · 2026-02-03T06:40:29Z

/retest

karthikjeeyar · 2026-02-03T10:22:24Z

/retest

ciiay · 2026-02-03T14:08:06Z

/retest

github-actions · 2026-02-03T14:59:19Z

The image is available at:

Signed-off-by: Yi Cai <yicai@redhat.com>

github-actions · 2026-02-03T16:29:45Z

The image is available at:

This reverts commit fa038a0.

github-actions · 2026-02-03T17:33:59Z

The image is available at:

Signed-off-by: Yi Cai <yicai@redhat.com>

github-actions · 2026-02-03T22:23:24Z

The image is available at:

christoph-jerolimov · 2026-02-04T00:43:09Z

Addressed two issues in main, let see

/retest

Signed-off-by: Yi Cai <yicai@redhat.com>

github-actions · 2026-02-04T02:19:01Z

The image is available at:

ciiay · 2026-02-04T03:10:03Z

/retest

karthikjeeyar · 2026-02-04T03:44:51Z

/retest

PatAKnight · 2026-02-04T04:03:02Z

-              <Route
-                path="/create"
-                element={
-                  <ScaffolderPage headerOptions={{ title: 'Self-service' }} />


@ciiay, I believe that your failing test has to do with the removal of the Self-service header. The test is expecting it on this page only to find that it has been replaced with Create a new component.

This PR adds 'templateListPage.title' translation string, and it needs to be updated in the all-v1.8_s3281-en.json test file as well.

Update Create a new component to Self-service in the /test directory here -

https://github.com/redhat-developer/rhdh/blob/main/translations/test/all-v1.8_s3281-en.json#L969

Thank you @karthikjeeyar for the help 🥇

christoph-jerolimov · 2026-02-04T05:34:09Z

/retest

github-actions · 2026-02-04T05:53:07Z

The image is available at:

teknaS47 · 2026-02-04T07:12:43Z

+  "catalog": {
+    "fr": {
+      "indexPage.createButtonTitle": "Self-service"
+    }
+  },
+  "catalog-import": {
+    "fr": {
+      "defaultImportPage.headerTitle": "Importer un dépôt Git existant",
+      "importInfoCard.title": "Importer un dépôt Git existant"
+    }
+  },
+  "scaffolder": {
+    "fr": {
+      "templateListPage.title": "Self-service",
+      "templateListPage.pageTitle": "Self-service",
+      "templateWizardPage.title": "Self-service",
+      "templateWizardPage.pageTitle": "Self-service",
+      "templateListPage.contentHeader.registerExistingButtonTitle": "Importer un dépôt Git existant"
+    }
+  },


Can we move these to backstage-fr.json? The keys are already there and can be updated. Same with the other 2 files.

teknaS47 · 2026-02-04T07:13:18Z

+  "catalog": {
+    "it": {
+      "indexPage.createButtonTitle": "Self-service"
+    }
+  },
+  "catalog-import": {
+    "it": {
+      "defaultImportPage.headerTitle": "Importa un repository Git esistente",
+      "importInfoCard.title": "Importa un repository Git esistente"
+    }
+  },
+  "scaffolder": {
+    "it": {
+      "templateListPage.title": "Self-service",
+      "templateListPage.pageTitle": "Self-service",
+      "templateWizardPage.title": "Self-service",
+      "templateWizardPage.pageTitle": "Self-service",
+      "templateListPage.contentHeader.registerExistingButtonTitle": "Importa un repository Git esistente"
+    }
+  },


Can we move these to backstage-it.json?

teknaS47 · 2026-02-04T07:13:33Z

+  "catalog": {
+    "ja": {
+      "indexPage.createButtonTitle": "セルフサービス"
+    }
+  },
+  "catalog-import": {
+    "ja": {
+      "defaultImportPage.headerTitle": "既存の Git リポジトリーのインポート",
+      "importInfoCard.title": "既存の Git リポジトリーのインポート"
+    }
+  },
+  "scaffolder": {
+    "ja": {
+      "templateListPage.title": "セルフサービス",
+      "templateListPage.pageTitle": "セルフサービス",
+      "templateWizardPage.title": "セルフサービス",
+      "templateWizardPage.pageTitle": "セルフサービス",
+      "templateListPage.contentHeader.registerExistingButtonTitle": "既存の Git リポジトリーのインポート"
+    }
+  },


Can we move these to backstage-ja.json?

Hi @teknaS47 @karthikjeeyar , thanks for taking care of this PR. The reason they are in rhdh-<locale>.json is they are override values specific from RHDH. The values in backstage-<locale>.json are translations for references collected from backstage repo. Why we have to move these values into backstage-<locale>.json files?

github-actions · 2026-02-04T07:36:09Z

The image is available at:

sonarqubecloud · 2026-02-04T08:07:01Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-02-04T08:47:47Z

The image is available at:

karthikjeeyar · 2026-02-04T10:11:46Z

/retest

christoph-jerolimov

Tested on a cluster.

Before next:

With this PR:

/lgtm
/approve

openshift-ci · 2026-02-04T11:48:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christoph-jerolimov, karthikjeeyar, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [christoph-jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-cherrypick-robot · 2026-02-04T12:59:29Z

@christoph-jerolimov: #4165 failed to apply on top of branch "release-1.9":

Applying: fix(i18n): fix translation override issue
Applying: follow up changes
Applying: Revert "follow up changes"
Applying: resolved review comments
Applying: take default const titleKey
Applying: update saffolder page title and fix the test values
Applying: add missing templateWizardPage title and pageTitle values
Applying: apply backstage overrides to backstage.<locale>.json
Using index info to reconstruct a base tree...
A	translations/backstage-fr.json
A	translations/backstage-it.json
A	translations/backstage-ja.json
Falling back to patching base and 3-way merge...
Auto-merging translations/core-plugins_v1.8_s3281-fr-C.json
CONFLICT (content): Merge conflict in translations/core-plugins_v1.8_s3281-fr-C.json
CONFLICT (modify/delete): translations/backstage-ja.json deleted in HEAD and modified in apply backstage overrides to backstage.<locale>.json. Version apply backstage overrides to backstage.<locale>.json of translations/backstage-ja.json left in tree.
CONFLICT (modify/delete): translations/backstage-it.json deleted in HEAD and modified in apply backstage overrides to backstage.<locale>.json. Version apply backstage overrides to backstage.<locale>.json of translations/backstage-it.json left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0008 apply backstage overrides to backstage.<locale>.json

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci Bot requested review from josephca and schultzp2020 February 3, 2026 02:08

karthikjeeyar approved these changes Feb 3, 2026

View reviewed changes

openshift-ci Bot assigned karthikjeeyar Feb 3, 2026

openshift-ci Bot added the lgtm label Feb 3, 2026

rohitkrai03 approved these changes Feb 3, 2026

View reviewed changes

rohitkrai03 added the approved label Feb 3, 2026

openshift-ci Bot removed the lgtm label Feb 3, 2026

ciiay requested review from karthikjeeyar and rohitkrai03 February 3, 2026 14:26

ciiay added 2 commits February 3, 2026 10:47

fix(i18n): fix translation override issue

13cb131

Signed-off-by: Yi Cai <yicai@redhat.com>

follow up changes

fa038a0

Signed-off-by: Yi Cai <yicai@redhat.com>

ciiay force-pushed the rhdhbugs-2564-fix-locale-override-issue branch from 7a24830 to fa038a0 Compare February 3, 2026 15:47

Revert "follow up changes"

2537c12

This reverts commit fa038a0.

resolved review comments

6f41ba4

Signed-off-by: Yi Cai <yicai@redhat.com>

take default const titleKey

73a8636

Signed-off-by: Yi Cai <yicai@redhat.com>

PatAKnight reviewed Feb 4, 2026

View reviewed changes

update saffolder page title and fix the test values

eaa5e93

add missing templateWizardPage title and pageTitle values

20badbe

teknaS47 reviewed Feb 4, 2026

View reviewed changes

apply backstage overrides to backstage.<locale>.json

5e52444

karthikjeeyar mentioned this pull request Feb 4, 2026

[release-1.9] chore: fix translation overrides and cleanup translation files #4184

Merged

christoph-jerolimov approved these changes Feb 4, 2026

View reviewed changes

openshift-ci Bot assigned christoph-jerolimov Feb 4, 2026

openshift-ci Bot added the lgtm label Feb 4, 2026

openshift-merge-bot Bot merged commit a46d1e5 into redhat-developer:main Feb 4, 2026
15 checks passed

rhdh-qodo-merge Bot mentioned this pull request Apr 22, 2026

chore(e2e): localization cleanup #4673

Merged

5 tasks

Uh oh!

Conversation

ciiay commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Which issue(s) does this PR fix

PR acceptance criteria

How to test changes / Special notes to the reviewer

Uh oh!

github-actions Bot commented Feb 3, 2026

Uh oh!

karthikjeeyar left a comment

Choose a reason for hiding this comment

Uh oh!

karthikjeeyar commented Feb 3, 2026

Uh oh!

rohitkrai03 left a comment

Choose a reason for hiding this comment

Uh oh!

christoph-jerolimov commented Feb 3, 2026

Uh oh!

openshift-cherrypick-robot commented Feb 3, 2026

Uh oh!

christoph-jerolimov commented Feb 3, 2026

Uh oh!

invincibleJai commented Feb 3, 2026

Uh oh!

karthikjeeyar commented Feb 3, 2026

Uh oh!

ciiay commented Feb 3, 2026

Uh oh!

github-actions Bot commented Feb 3, 2026

Uh oh!

github-actions Bot commented Feb 3, 2026

Uh oh!

github-actions Bot commented Feb 3, 2026

Uh oh!

github-actions Bot commented Feb 3, 2026

Uh oh!

christoph-jerolimov commented Feb 4, 2026

Uh oh!

github-actions Bot commented Feb 4, 2026

Uh oh!

ciiay commented Feb 4, 2026

Uh oh!

karthikjeeyar commented Feb 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

christoph-jerolimov commented Feb 4, 2026

Uh oh!

github-actions Bot commented Feb 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 4, 2026

Uh oh!

sonarqubecloud Bot commented Feb 4, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Feb 4, 2026

Uh oh!

karthikjeeyar commented Feb 4, 2026

Uh oh!

christoph-jerolimov left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Feb 4, 2026

ciiay commented Feb 3, 2026 •

edited

Loading