test: skip orchestrator failswitch-workflow tests on AKS by gustavolira · Pull Request #4443 · redhat-developer/rhdh

gustavolira · 2026-03-23T13:18:06Z

Summary

Skip failswitch-workflow.spec.ts orchestrator tests on AKS, where the Orchestrator plugin is disabled
The other two orchestrator test suites (greeting-workflow.spec.ts and workflow-all-runs-validations.spec.ts) already skip AKS
Orchestrator infrastructure and plugins are already disabled for AKS in helm values — this just aligns the test skip

Test plan

Verify nightly AKS jobs no longer fail on failswitch-workflow.spec.ts

🤖 Generated with Claude Code

Orchestrator plugin is disabled on AKS but this test suite was not being skipped, causing consistent timeout failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

rhdh-qodo-merge · 2026-03-23T13:18:19Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🔒 No security concerns identified
⚡ Recommended focus areas for review Coverage Gap Skipping this suite on AKS reduces signal for AKS-specific regressions; confirm there is alternative AKS coverage for the underlying workflows (or an explicit justification that orchestrator functionality is intentionally unsupported on AKS). test.describe("Orchestrator failswitch workflow tests", () => { test.skip(() => skipIfJobName(JOB_NAME_PATTERNS.OSD_GCP)); // skipping orchestrator tests on OSD-GCP due to infra not being installed test.skip(() => skipIfJobName(JOB_NAME_PATTERNS.GKE)); // skipping orchestrator tests on GKE - plugins disabled to save disk space test.skip(() => skipIfJobName(JOB_NAME_PATTERNS.AKS)); // skipping orchestrator tests on AKS - plugins disabled Maintainability Repeated per-suite skip logic can drift over time; consider centralizing environment-based orchestrator skipping (e.g., shared helper or a single guard used by all orchestrator specs) to ensure consistency across suites. test.skip(() => skipIfJobName(JOB_NAME_PATTERNS.OSD_GCP)); // skipping orchestrator tests on OSD-GCP due to infra not being installed test.skip(() => skipIfJobName(JOB_NAME_PATTERNS.GKE)); // skipping orchestrator tests on GKE - plugins disabled to save disk space test.skip(() => skipIfJobName(JOB_NAME_PATTERNS.AKS)); // skipping orchestrator tests on AKS - plugins disabled
📄 References redhat-developer/rhdh/e2e-tests/playwright/e2e/plugins/orchestrator/workflow-all-runs-validations.spec.ts [1-31] redhat-developer/rhdh/e2e-tests/playwright/e2e/plugins/orchestrator/token-propagation-workflow.spec.ts [37-239]

rhdh-qodo-merge · 2026-03-23T13:18:26Z

PR Type

Tests

Description

Skip orchestrator failswitch-workflow tests on AKS
Aligns test configuration with disabled orchestrator plugins
Prevents timeout failures in AKS test environments

File Walkthrough

Relevant files

Tests

failswitch-workflow.spec.ts `Add AKS skip condition to orchestrator tests` e2e-tests/playwright/e2e/plugins/orchestrator/failswitch-workflow.spec.ts Added skip condition for AKS environment to `failswitch-workflow.spec.ts` Prevents orchestrator tests from running on AKS where plugins are disabled Aligns with existing skip patterns for OSD-GCP and GKE environments	+1/-0

rhdh-qodo-merge · 2026-03-23T13:19:45Z

PR Code Suggestions ✨

Explore these optional code suggestions:

Category Suggestion Impact

Possible issue

✅ ~~Use boolean condition for test.skip~~

Suggestion Impact:

The explicit test.skip callback usages (including AKS) were removed and replaced with a shared helper (skipOrchestratorOnUnsupportedPlatforms(test)) to handle skipping on unsupported platforms, changing how skipping is expressed rather than applying the exact boolean+reason call.

code diff:

-import { skipIfJobName } from "../../../utils/helper";
-import { JOB_NAME_PATTERNS } from "../../../utils/constants";
+import { skipOrchestratorOnUnsupportedPlatforms } from "../../../utils/helper";
 import { LogUtils } from "../../audit-log/log-utils";
 
 test.describe("Orchestrator failswitch workflow tests", () => {
-  test.skip(() => skipIfJobName(JOB_NAME_PATTERNS.OSD_GCP)); // skipping orchestrator tests on OSD-GCP due to infra not being installed
-  test.skip(() => skipIfJobName(JOB_NAME_PATTERNS.GKE)); // skipping orchestrator tests on GKE - plugins disabled to save disk space
-  test.skip(() => skipIfJobName(JOB_NAME_PATTERNS.AKS)); // skipping orchestrator tests on AKS - plugins disabled
+  skipOrchestratorOnUnsupportedPlatforms(test);

Modify the test.skip call for JOB_NAME_PATTERNS.AKS to pass the boolean
condition from skipIfJobName and the reason as separate arguments, instead of
using a callback function.

e2e-tests/playwright/e2e/plugins/orchestrator/failswitch-workflow.spec.ts [12]

-test.skip(() => skipIfJobName(JOB_NAME_PATTERNS.AKS)); // skipping orchestrator tests on AKS - plugins disabled
+test.skip(skipIfJobName(JOB_NAME_PATTERNS.AKS), 'skipping orchestrator tests on AKS - plugins disabled');

[Suggestion processed]

Suggestion importance[1-10]: 2

__

Why: The suggestion proposes a minor stylistic change to the test.skip syntax which is functionally equivalent and a matter of developer preference, offering minimal impact.

Low

Update

gustavolira · 2026-03-23T13:28:53Z

/test ?

gustavolira · 2026-03-23T13:29:09Z

/test e2e-aks-helm-nightly

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-23T13:40:50Z

The container image build workflow finished with status: cancelled.

Consolidate repeated skip blocks across all orchestrator test files into a single reusable helper function, so adding a new platform only requires a one-line change. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-23T13:43:16Z

The container image build workflow finished with status: cancelled.

gustavolira · 2026-03-23T14:08:32Z

/test e2e-aks-helm-nightly

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-23T14:09:25Z

The container image build workflow finished with status: cancelled.

gustavolira · 2026-03-23T14:10:12Z

/test e2e-aks-helm-nightly

github-actions · 2026-03-23T14:51:51Z

Image was built and published successfully. It is available at:

Use IS_OPENSHIFT env var in playwright.config.ts to skip orchestrator tests on all non-OpenShift platforms (AKS, EKS, GKE) instead of per-file skip calls. This removes the need to update every test file when a new platform is added. Reverts the skipOrchestratorOnUnsupportedPlatforms helper in favor of this cleaner config-level approach. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-23T14:55:01Z

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

sonarqubecloud · 2026-03-23T14:55:21Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

zdrapela

LGTM

test: skip orchestrator failswitch-workflow tests on AKS

0337290

Orchestrator plugin is disabled on AKS but this test suite was not being skipped, causing consistent timeout failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

openshift-ci Bot requested review from rostalan and zdrapela March 23, 2026 13:18

rhdh-qodo-merge Bot added the Review effort 1/5 label Mar 23, 2026

rhdh-qodo-merge Bot added the Tests label Mar 23, 2026

zdrapela reviewed Mar 23, 2026

View reviewed changes

Comment thread e2e-tests/playwright/e2e/plugins/orchestrator/failswitch-workflow.spec.ts Outdated

test: also skip orchestrator failswitch-workflow tests on EKS

80eda15

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

style: fix prettier formatting

a33d883

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

zdrapela approved these changes Mar 23, 2026

View reviewed changes

openshift-ci Bot assigned zdrapela Mar 23, 2026

openshift-ci Bot added the lgtm label Mar 23, 2026

openshift-merge-bot Bot merged commit 88c5a53 into redhat-developer:release-1.9 Mar 23, 2026
15 checks passed

Uh oh!

Conversation

gustavolira commented Mar 23, 2026

Summary

Test plan

Uh oh!

rhdh-qodo-merge Bot commented Mar 23, 2026

PR Reviewer Guide 🔍

Uh oh!

rhdh-qodo-merge Bot commented Mar 23, 2026

PR Type

Description

File Walkthrough

Uh oh!

rhdh-qodo-merge Bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions ✨

Uh oh!

gustavolira commented Mar 23, 2026

Uh oh!

gustavolira commented Mar 23, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 23, 2026

Uh oh!

github-actions Bot commented Mar 23, 2026

Uh oh!

gustavolira commented Mar 23, 2026

Uh oh!

github-actions Bot commented Mar 23, 2026

Uh oh!

gustavolira commented Mar 23, 2026

Uh oh!

github-actions Bot commented Mar 23, 2026

Uh oh!

github-actions Bot commented Mar 23, 2026

Uh oh!

sonarqubecloud Bot commented Mar 23, 2026

Quality Gate passed

Uh oh!

zdrapela left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rhdh-qodo-merge Bot commented Mar 23, 2026 •

edited

Loading