test(e2e): enable instance-health-check and smoke-test on the cluster-free harness

[gustavolira]

Description

Widens the cluster-free E2E harness (RHIDP-13501) with the next seven specs from the enablement queue in docs/e2e-tests/layer-migration-matrix.md — the PR check goes from 4 to 14 test cases:

• instance-health-check.spec.ts — GET /healthcheck, zero plugin/config dependencies.
• smoke-test.spec.ts — guest sign-in + home-page welcome heading.
• home-page-customization.spec.ts — all three tests; the CI home-page card customization (Placeholder/Markdown/Featured Docs/Random Joke/Top + Recently Visited) is mirrored into app-config.local-e2e.yaml.
• plugins/frontend/sidebar.spec.ts — CI menu customization (Test enabled/nested, techdocs Favorites → Docs, Test_i) mirrored into the overlay, plus the techdocs frontend plugin added to the harness OCI set (the /docs TechDocsIndexPage route is a dynamic plugin and 404s without it).
• settings.spec.ts — CI i18n.locales + userSettings.persistence mirrored, and the guest ownership entities ("Guest User", member of team-a — ingested from Keycloak in CI) provided as a minimal User/Group pair via a catalog.locations file entry; the guest sign-in resolver then issues the same ownership refs as in-cluster.
• plugins/user-settings-info-card.spec.ts — CI buildInfo card customization mirrored.
• plugins/application-provider.spec.ts + plugins/application-listener.spec.ts — the application provider/listener test plugins are OCI-only builds that CI installs through its Helm values (values_showcase.yaml); the harness now installs the same packages with the same pluginConfig.

All specs run unmodified apart from the @cluster-free tag and the testMatch allowlist entries. One commit per spec (or small pair), each validated green locally before push.

Skipped (documented in docs/e2e-tests/local-e2e-harness.md): plugins/licensed-users-info-backend — the plugin is not published to the overlays OCI registry.

Enabling change: /healthcheck on the frontend origin

instance-health-check and smoke-test hit /healthcheck relative to the frontend baseURL. In-cluster that works because the backend serves the app and the health endpoint on a single origin; the legacy app dev server previously had no route for it. This PR adds a dev-only proxy entry to packages/app/package.json (consumed by the janus-cli webpack dev server) forwarding /healthcheck to the backend, mirroring the production single-origin behavior. The e2e-cluster-free.yaml path filter now also watches packages/app/package.json since the harness depends on it.

Validation

• 14/14 tests green locally on playwright.legacy-local.config.ts; each commit also validated by the "E2E Cluster-free / e2e" PR check (~4-5 min).
• fmt / lint / prettier clean. The pre-existing tsc error in playwright/support/coverage/test.ts is unrelated (touched by refactor(e2e): consolidate auth and runtime test seams #5022).

Part of epic RHIDP-13501 (E2E Test Optimization). Follow-up to #5005.

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.77%. Comparing base (db354ff) to head (82e4a42).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5057      +/-   ##
==========================================
- Coverage   55.39%   54.77%   -0.62%     
==========================================
  Files         122      110      -12     
  Lines        2365     2147     -218     
  Branches      563      542      -21     
==========================================
- Hits         1310     1176     -134     
+ Misses       1049      969      -80     
+ Partials        6        2       -4     

Flag	Coverage Δ
rhdh	54.77% <ø> (-0.62%)	⬇️

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db354ff...82e4a42. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

The container image build workflow finished with status: cancelled.

[github-actions]

The container image build workflow finished with status: cancelled.

[github-actions]

The container image build workflow finished with status: cancelled.

[github-actions]

The container image build workflow finished with status: cancelled.

[github-actions]

The container image build workflow finished with status: cancelled.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Image was built and published successfully. It is available at:

• quay.io/rhdh-community/rhdh:pr-5057
• quay.io/rhdh-community/rhdh:pr-5057-82e4a427

[gustavolira]

/agentic_review

[rhdh-qodo-merge]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 📜 Skill insights (0)

Context used

⚠️ Tickets: not configured — ticket URL found in PR but could not be fetched — check ticket provider credentials

✅ Compliance rules (platform): 46 rules

✅ Skills: e2e-verify-fix, e2e-diagnose-and-fix

1. settings.spec.ts lacks beforeAll 📘 Rule violation ⚙ Maintainability

Description

e2e-tests/playwright/e2e/settings.spec.ts and
e2e-tests/playwright/e2e/plugins/frontend/sidebar.spec.ts lack a test.beforeAll hook that pushes
the required component annotation, and instead currently add annotations in test.beforeEach. This
violates the requirement that each spec file must declare its component annotation in
test.beforeAll for consistent reporting.

Code

e2e-tests/playwright/e2e/settings.spec.ts[26]

+  test(`Verify settings page`, { tag: "@cluster-free" }, async () => {

Relevance

⭐ Low

Repo historically adds component annotations in beforeEach (not beforeAll), e.g., reporting metadata
in PRs #3618/#3333.

PR-#3618
PR-#3333

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

PR Compliance ID 1834 requires every spec file to include a test.beforeAll hook that pushes a
component annotation. In both settings.spec.ts and sidebar.spec.ts, there is no beforeAll hook
present at all—only a beforeEach that pushes annotations—so neither file follows the mandated
pattern and therefore fails the compliance requirement.

Rule 1834: Every e2e spec file must have a component annotation in test.beforeAll
e2e-tests/playwright/e2e/settings.spec.ts[12-22]
e2e-tests/playwright/e2e/plugins/frontend/sidebar.spec.ts[10-24]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Both `e2e-tests/playwright/e2e/settings.spec.ts` and `e2e-tests/playwright/e2e/plugins/frontend/sidebar.spec.ts` are missing a `test.beforeAll` hook that pushes the required component annotation; the annotation is currently added in `test.beforeEach`.

## Issue Context
Compliance (PR Compliance ID 1834) requires component annotations to be present in `test.beforeAll` for every spec file to ensure consistent reporting.

## Fix Focus Areas
- e2e-tests/playwright/e2e/settings.spec.ts[12-22]
- e2e-tests/playwright/e2e/plugins/frontend/sidebar.spec.ts[10-24]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

[openshift-ci]

@gustavolira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ocp-helm	82e4a42	link	unknown	/test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.