Skip to content

[release-1.10] chore(deps): upgrade js-cookie to 3.0.8 in in root and dynamic-plugins#5091

Open
Omar-AlJaljuli wants to merge 1 commit into
redhat-developer:release-1.10from
Omar-AlJaljuli:jscookie-1.10
Open

[release-1.10] chore(deps): upgrade js-cookie to 3.0.8 in in root and dynamic-plugins#5091
Omar-AlJaljuli wants to merge 1 commit into
redhat-developer:release-1.10from
Omar-AlJaljuli:jscookie-1.10

Conversation

@Omar-AlJaljuli

Copy link
Copy Markdown
Contributor

Upgrade it directly and through react-use->17.6.1. Resolutions required to upgrade.

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@Omar-AlJaljuli

Copy link
Copy Markdown
Contributor Author

/retest

Comment thread dynamic-plugins/package.json Outdated
@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.24%. Comparing base (da65cdf) to head (295d85b).

Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.10    #5091       +/-   ##
=================================================
+ Coverage         41.03%   69.24%   +28.21%     
=================================================
  Files               121      123        +2     
  Lines              2220     4920     +2700     
  Branches            563      562        -1     
=================================================
+ Hits                911     3407     +2496     
- Misses             1304     1507      +203     
- Partials              5        6        +1     
Flag Coverage Δ
install-dynamic-plugins 92.44% <ø> (?)
rhdh 41.03% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da65cdf...295d85b. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JessicaJHee JessicaJHee changed the title chore(deps): upgrade js-cookie to 3.0.8 in in root and dynamic-plugins [release-1.10] chore(deps): upgrade js-cookie to 3.0.8 in in root and dynamic-plugins Jul 15, 2026
Upgrade it directly and through react-use->17.6.1.
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@Omar-AlJaljuli

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@Omar-AlJaljuli

Copy link
Copy Markdown
Contributor Author

/retest

@JessicaJHee

Copy link
Copy Markdown
Member

/test e2e-ocp-helm

@Omar-AlJaljuli

Copy link
Copy Markdown
Contributor Author

e2e test startup failure coming from unrelated issue:

======= Adding new dynamic plugin configuration for @backstage-community/plugin-todo
Traceback (most recent call last):
File "/opt/app-root/src/install-dynamic-plugins.py", line 1556, in
main()
File "/opt/app-root/src/install-dynamic-plugins.py", line 1510, in main
merge_plugin(plugin, all_plugins, dynamic_plugins_file, level=1)
File "/opt/app-root/src/install-dynamic-plugins.py", line 151, in merge_plugin
return OciPackageMerger(plugin, dynamic_plugins_file, all_plugins).merge_plugin(level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/app-root/src/install-dynamic-plugins.py", line 611, in merge_plugin
raise InstallException(
InstallException: Cannot use {{inherit}} for oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-lightspeed: no existing plugin configuration found. Ensure a plugin from this image is defined in an included file with an explicit version.

@Omar-AlJaljuli

Copy link
Copy Markdown
Contributor Author

/retest

@alizard0

Copy link
Copy Markdown
Member

/retest-required

@kim-tsao kim-tsao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 20, 2026
@alizard0

Copy link
Copy Markdown
Member

/retest

@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown

@Omar-AlJaljuli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm 295d85b link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants