Skip to content

chore(ci): remove unused Xvfb from E2E test runner [release-1.10] - #5189

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:release-1.10from
zdrapela:chore/remove-ci-xvfb-release-1.10
Jul 29, 2026
Merged

chore(ci): remove unused Xvfb from E2E test runner [release-1.10]#5189
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:release-1.10from
zdrapela:chore/remove-ci-xvfb-release-1.10

Conversation

@zdrapela

@zdrapela zdrapela commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

Jira: RHIDP-15894

Test plan

  • Release-branch e2e job reaches Playwright without Missing X server / DISPLAY errors
  • Job log has no _XSERVTransmkdir / xkbcomp XF86* warnings

Playwright runs headless in CI, so the virtual display only added
log noise with no functional value.

RHIDP-15894
@rhdh-qodo-merge

rhdh-qodo-merge Bot commented Jul 29, 2026

Copy link
Copy Markdown

PR Summary by Qodo

CI: drop unused Xvfb/DISPLAY setup from E2E Playwright runner (release-1.10)

⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Remove Xvfb startup/shutdown and DISPLAY export from the E2E test runner.
• Keep Playwright running headless in CI while reducing noisy X server warnings.
Diagram

graph TD
  A["CI E2E job"] --> B["testing.sh"] --> C["Playwright (headless)"] --> D["Test results artifacts"]

  subgraph Legend
    direction LR
    _job["CI job"] ~~~ _script["Script"] ~~~ _tool["Test tool"] ~~~ _art["Artifacts"]
  end
Loading
High-Level Assessment

Current approach is optimal: since Playwright runs headless in CI, removing Xvfb/DISPLAY reduces log noise without changing test behavior. A conditional Xvfb setup (only when headed mode is enabled) was considered but adds complexity not needed for this pipeline.

Files changed (1) +0 / -5

Other (1) +0 / -5
testing.shRemove Xvfb/DISPLAY setup and teardown from testing::run_tests +0/-5

Remove Xvfb/DISPLAY setup and teardown from testing::run_tests

• Deletes the background Xvfb start and DISPLAY export before running Playwright, and removes the corresponding pkill cleanup. This keeps the E2E runner aligned with headless Playwright execution and avoids X server-related log warnings.

.ci/pipelines/lib/testing.sh

@zdrapela zdrapela closed this Jul 29, 2026
@rhdh-qodo-merge

rhdh-qodo-merge Bot commented Jul 29, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

To customize comments, go to the Qodo configuration screen, or learn more in the docs.

Previous review results

Review updated until commit b3aa808 ⚖️ Balanced

Results up to commit b3aa808 ⚖️ Balanced


No changes from previous review

Qodo Logo

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.60%. Comparing base (2a65941) to head (b3aa808).
⚠️ Report is 1 commits behind head on release-1.10.

Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.10    #5189       +/-   ##
=================================================
+ Coverage         41.03%   69.60%   +28.57%     
=================================================
  Files               121      111       -10     
  Lines              2220     4702     +2482     
  Branches            563      536       -27     
=================================================
+ Hits                911     3273     +2362     
- Misses             1303     1428      +125     
+ Partials              6        1        -5     
Flag Coverage Δ
install-dynamic-plugins 92.44% <ø> (?)
rhdh 38.81% <ø> (-2.23%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a65941...b3aa808. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@zdrapela zdrapela reopened this Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

@sonarqubecloud

Copy link
Copy Markdown

@rhdh-qodo-merge

Copy link
Copy Markdown

Code review by qodo was updated up to the latest commit b3aa808

@openshift-merge-bot
openshift-merge-bot Bot merged commit 56b297f into redhat-developer:release-1.10 Jul 29, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants