Skip to content

[release-1.9] chore(ci): remove unused Xvfb from E2E test runner - #5190

Open
zdrapela wants to merge 1 commit into
redhat-developer:release-1.9from
zdrapela:chore/remove-ci-xvfb-release-1.9
Open

[release-1.9] chore(ci): remove unused Xvfb from E2E test runner#5190
zdrapela wants to merge 1 commit into
redhat-developer:release-1.9from
zdrapela:chore/remove-ci-xvfb-release-1.9

Conversation

@zdrapela

@zdrapela zdrapela commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

Playwright runs headless in CI, so the virtual display only added _XSERVTransmkdir / xkbcomp log noise.

Test plan

  • Confirm PR diff is only .ci/pipelines/utils.sh
  • e2e-ocp-helm (or equivalent release-1.9 e2e) reaches Playwright without Missing X server / DISPLAY errors
  • Job log has no _XSERVTransmkdir / xkbcomp XF86* warnings

Cherry-pick of RHIDP-15894 / redhat-developer#5188 for release-1.9.
On this branch the Xvfb setup lives in utils.sh (testing.sh not present).

Playwright runs headless in CI, so the virtual display only added log noise.
@openshift-ci
openshift-ci Bot requested review from gustavolira and rostalan July 29, 2026 13:03
@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

CI: remove unused Xvfb/DISPLAY setup from E2E test runner (release-1.9)

⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Remove Xvfb startup and DISPLAY export from the E2E test runner.
• Drop Xvfb cleanup step to reduce CI log noise for headless Playwright.
Diagram

graph TD
  A["CI E2E job"] --> B["utils.sh: run_tests"] --> C("Playwright (headless)")
  B -. "removed" .-> D["Xvfb + DISPLAY"]
Loading
High-Level Assessment

Removing Xvfb is the simplest and correct approach given Playwright runs headless in CI; keeping Xvfb (even behind a flag) would add ongoing maintenance and doesn’t provide value unless headed-browser runs are a supported CI mode.

Files changed (1) +0 / -5

Other (1) +0 / -5
utils.shRemove Xvfb/DISPLAY setup and teardown from run_tests() +0/-5

Remove Xvfb/DISPLAY setup and teardown from run_tests()

• Deletes the background Xvfb launch and DISPLAY export before running Playwright-based E2E tests. Also removes the corresponding 'pkill Xvfb' cleanup step after tests complete.

.ci/pipelines/utils.sh

@sonarqubecloud

Copy link
Copy Markdown

@rhdh-qodo-merge

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

To customize comments, go to the Qodo configuration screen, or learn more in the docs.

Qodo Logo

@zdrapela

Copy link
Copy Markdown
Member Author

/retest

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@zdrapela

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown

@zdrapela: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm 203ce94 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants