Fix macOS CI: upgrade test-electron and Node for VS Code binary rename - #640
Merged
Conversation
VS Code 1.110+ renamed the macOS binary from Contents/MacOS/Electron to Contents/MacOS/Code, and the compatibility symlink was removed on 2026-07-20 (microsoft/vscode#326502). This broke @vscode/test-electron 2.x which hardcodes the old path, causing ENOENT on macOS CI runners. - Upgrade @vscode/test-electron from ^2.4.0 to ^3.1.0 (includes the fix from microsoft/vscode-test#350) - Upgrade typescript from ^5.3.3 to ~5.9.3 (needed for Buffer generic syntax in the new test-electron type declarations) - Bump CI Node version from 20 to 22 (required by test-electron 3.x) Fixes #639 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The afterEach hook in extensionUITest looked for a "Clear Extensions Search Results" button that may not exist (no search is performed in these tests, and newer VS Code versions may omit or rename it). Wrap in try/catch and add missing await on isEnabled(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…Toolkit' The extension displayName was renamed but RSP_CONNECTOR_NAME was not updated, causing the "Server Connector extension is installed" test to fail. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vscode/test-electronfrom^2.4.0to^3.1.0— fixes macOSENOENTcaused by VS Code renaming its binary fromContents/MacOS/ElectrontoContents/MacOS/Code(symlink removed 2026-07-20 in chore: cleanup some debt comments microsoft/vscode#326502, fix in fix(darwin): resolve executable via CFBundleExecutable with Electron fallback microsoft/vscode-test#350)typescriptfrom^5.3.3to~5.9.3— needed forBuffer<ArrayBufferLike>generic syntax in new test-electron type declarations@vscode/test-electron3.x (engines.node >= 22)Fixes #639
Test plan
spawn .../Contents/MacOS/Electron ENOENT)🤖 Generated with Claude Code