Handle invalidate messages from topic __redis__:invalidate#3326
Handle invalidate messages from topic __redis__:invalidate#3326chisenberg wants to merge 2 commits intoredis:masterfrom
Conversation
6e02d7c to
2e886f8
Compare
|
@chisenberg thank you for the contribution. Would you please add tests for the code you are introducing? |
ndyakov
left a comment
There was a problem hiding this comment.
@chisenberg are you using the client for a client side caching ? We don't have it inside the client for now, but would like to add it in the near future.
|
Hey @chisenberg , |
Sorry for the delay. Yes, we are using the client side caching feature on our product. It is working great on my fork but I still didn't write the unit tests that you asked. |
|
Hello @chisenberg, There is no way for us to merge this if there are no tests. Would you mind adding tests? |
This pull request handles the "invalidate" messages sent by redis when enabling CLIENT TRACKING and subscribing to topic "__redis__:invalidate" topic.
The invalidated keys are sent on the PayloadSlice field of the redis.Message struct.