Fix failing test_keys unit test#125
Closed
mlesniewski-reef wants to merge 2 commits into
Closed
Conversation
This is a fix for the `test_keys` unit tests, which started failing after commit 043b919 (Fix B2Api.get_key() returning wrong key if `key_id` is incorrect) was added to b2sdk.
mlesniewski-reef
force-pushed
the
fix_unit_tests
branch
from
a00d288 to
9737bc2
Compare
mlesniewski-reef
force-pushed
the
fix_unit_tests
branch
from
9737bc2 to
aa7596f
Compare
It appears the intention in noxfile.py was to always run unit tests in the CI with the latest SDK version, downloaded straight from git. This didn't work, because right after installing the SDK from git, the installation got overwritten with the `pip install -e .` command. This also introduces changes which ensure that `liccheck` is run with the SDK version that has been installed.
mlesniewski-reef
force-pushed
the
fix_unit_tests
branch
from
aa7596f to
fb1bd6a
Compare
mpnowacki-reef
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for the
test_keysunit tests, which started failing after commit 043b919 (Fix B2Api.get_key() returning wrong key ifkey_idis incorrect) was added to b2sdk.