Skip to content

site requires internal components to build pyi#6362

Merged
adhami3310 merged 4 commits into
mainfrom
site-requires-internal-components-to-build-pyi
Apr 22, 2026
Merged

site requires internal components to build pyi#6362
adhami3310 merged 4 commits into
mainfrom
site-requires-internal-components-to-build-pyi

Conversation

@adhami3310
Copy link
Copy Markdown
Member

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 22, 2026

Greptile Summary

This PR adds reflex-components-internal as a dependency to reflex-site-shared in two places: the runtime [project] dependencies and the [tool.hatch.build.hooks.reflex-pyi] build hook, fixing .pyi stub generation which required the internal components package. The uv.lock is updated accordingly to resolve the editable local package.

Confidence Score: 5/5

Safe to merge — minimal, targeted dependency addition with a properly updated lock file.

Two-file change that adds a missing dependency needed for pyi generation. No logic changes, no security concerns, and the lock file is consistent with the manifest.

No files require special attention.

Important Files Changed

Filename Overview
packages/reflex-site-shared/pyproject.toml Adds reflex-components-internal to both runtime [project] dependencies and the [tool.hatch.build.hooks.reflex-pyi] build hook dependencies, fixing the pyi generation build.
uv.lock Lock file updated to include reflex-components-internal as an editable local package dependency for reflex-site-shared, consistent with pyproject.toml changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[reflex-site-shared build] --> B{hatch-reflex-pyi hook}
    B --> C[reflex-components-internal\nnow available ✅]
    B --> D[reflex-components-radix]
    B --> E[reflex-components-core]
    B --> F[... other component packages]
    C --> G[.pyi stubs generated successfully]
    D --> G
    E --> G
    F --> G

    A --> H[Runtime install]
    H --> I[reflex]
    H --> C
Loading

Reviews (1): Last reviewed commit: "site requires internal components to bui..." | Re-trigger Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 22, 2026

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing site-requires-internal-components-to-build-pyi (4a1b8f0) with main (7c1e017)

Open in CodSpeed

@adhami3310 adhami3310 merged commit bdc2ee7 into main Apr 22, 2026
68 checks passed
@adhami3310 adhami3310 deleted the site-requires-internal-components-to-build-pyi branch April 22, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants