Skip to content

fix(hosting-cli): make ScaleParams.as_json() side-effect free #6415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masenf merged 1 commit into from
May 1, 2026
Merged

fix(hosting-cli): make ScaleParams.as_json() side-effect free #6415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/reflex-hosting-cli/src/reflex_cli/utils/hosting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,16 +216,15 @@ def as_json(self) -> dict[str, Any]:
dict: The object as a dictionary.

"""
if self.type is None:
self.type = ScaleType.REGION
effective_type = self.type or ScaleType.REGION
return (
{
"type": str(self.type.value),
"type": str(effective_type.value),
"size": self.vm_type,
}
if self.type == ScaleType.SIZE
if effective_type == ScaleType.SIZE
else {
"type": str(self.type.value),
"type": str(effective_type.value),
"regions": {
region["name"]: region["number_of_machines"]
for region in self.regions
Expand Down
13 changes: 13 additions & 0 deletions tests/units/reflex_cli/utils/test_hosting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
import pytest
from pytest_mock import MockerFixture, MockFixture
from reflex_cli.utils.hosting import (
ScaleParams,
ScaleType,
authenticated_token,
delete_token_from_config,
get_authenticated_client,
Expand Down Expand Up @@ -164,3 +166,14 @@ def test_authenticate_with_env_token_in_non_interactive_mode(mocker: MockerFixtu

assert result == mock_authenticated_client
mock_get_auth_client.assert_called_once_with(None)


def test_scale_params_as_json_is_pure_when_type_is_unspecified():
"""ScaleParams.as_json should not mutate type when defaulting scale type."""
scale_params = ScaleParams(vm_type="shared-1x")

first = scale_params.as_json()
second = scale_params.as_json()

assert scale_params.type is None
assert first == second == {"type": ScaleType.REGION.value, "regions": {}}
Loading