Skip to content

fix(docs): remove dead docs breadcrumb segment filter #6427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BABTUNA wants to merge 5 commits into
base: main
Choose a base branch
from
+13 −2
Open

fix(docs): remove dead docs breadcrumb segment filter #6427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5a7bf7
fix(docs): remove dead breadcrumb docs segment filter
BABTUNA Apr 30, 2026
50f0379
pre-commit
masenf May 1, 2026
b495e09
Merge branch 'main' into fix-docs-breadcrumb-dead-filter
FarhanAliRaza May 21, 2026
788bbc9
refactor: move the test to already available file instead of creating…
FarhanAliRaza May 21, 2026
26c91ea
refactor: make test proper
FarhanAliRaza May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/app/reflex_docs/templates/docpage/docpage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,8 +667,8 @@ def breadcrumb(path: str, nav_sidebar: rx.Component, doc_content: str | None = N
docs_sidebar_drawer,
)

# Split the path into segments, removing 'docs'.
segments = [segment for segment in path.split("/") if segment and segment != "docs"]
# Split the path into non-empty segments.
segments = [segment for segment in path.split("/") if segment]

# Initialize an empty list to store the breadcrumbs and their separators
breadcrumbs = []
Expand Down
11 changes: 11 additions & 0 deletions docs/app/tests/test_breadcrumbs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,14 @@ def test_enterprise_parent_breadcrumb_uses_overview_route(monkeypatch):
assert 'to:"/enterprise/overview/"' in rendered
assert 'to:"/enterprise/ag-grid/"' in rendered
assert 'to:"/enterprise/ag-grid/pivot-mode/"' in rendered


def test_breadcrumb_keeps_docs_segment_when_present_in_path():
"""Every non-empty path segment should produce a crumb, including 'docs'."""
from reflex_docs.templates.docpage.docpage import breadcrumb

rendered = str(breadcrumb("/docs/ai/integrations/", rx.box()))

assert 'to:"/docs"' in rendered
assert 'to:"/docs/ai"' in rendered
assert 'to:"/docs/ai/integrations"' in rendered
Loading