pin action commits#6498
Conversation
Greptile SummaryThis PR pins all GitHub Actions references from floating version tags (e.g.,
Confidence Score: 4/5Safe to merge for most workflows; the publish workflow deserves a closer look before the next PyPI release. Almost all changes are mechanical SHA-pinning of existing action tags with low risk. The standout is .github/workflows/publish.yml — the newly added uv and Python version pins are the only part of this PR that could cause a live failure. Important Files Changed
Reviews (1): Last reviewed commit: "pin action commits" | Re-trigger Greptile |
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v7 | ||
| uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0 | ||
| with: | ||
| version: "0.11.14" | ||
| python-version: "3.14.5" | ||
| enable-cache: false | ||
| restore-cache: false | ||
| save-cache: false | ||
| cache-python: false |
There was a problem hiding this comment.
Unexplained version pins added to publish workflow
Beyond the SHA pinning goal of this PR, two hard-coded version constraints were added to the Install uv step that didn't exist before: version: "0.11.14" (pins the uv tool itself) and python-version: "3.14.5" (pins a very specific CPython patch). Neither value appears in any other workflow. If Python 3.14.5 is not yet available in the GitHub-hosted Ubuntu image at publish time, setup-uv will fail here — blocking the entire PyPI release. The uv build and uv publish commands do not inherently require a single specific Python patch version, so this level of pinning in the critical publish path should be accompanied by an explanation.
There was a problem hiding this comment.
the pinning to minimize potential latest fake versions, ideally we should be able to set a SHA but it doesn't look like it
Merging this PR will not alter performance
Comparing Footnotes
|
No description provided.