Release the WebGL context in ChartView.destroy()#123
Merged
Conversation
A full-payload republish rebuilds the view (destroy + new ChartView, hence a new GL context), and browsers cap live contexts (~16 in Chrome). destroy() freed GPU resources but never released the context itself, so destroyed contexts lingered until GC and — under repeated republishes, e.g. an on_view_change-driven figure refresh — tripped the browser's "too many active WebGL contexts" eviction. destroy() now releases the context via WEBGL_lose_context after freeing resources; the context-lost listeners are already removed and _destroyed is set, so the resulting event starts no recovery. Rebuild the committed static bundles and record the behavior in the dossier (§18) and renderer-architecture (R8).
Merging this PR will not alter performance
Comparing Footnotes
|
Greptile SummaryThis PR releases each WebGL context when its chart view is destroyed. The main changes are:
Confidence Score: 5/5This looks safe to merge. No blocking issues found in the changed code. No files need additional attention.
What T-Rex did
Important Files Changed
Reviews (1): Last reviewed commit: "Release the WebGL context in ChartView.d..." | Re-trigger Greptile |
Alek99
added a commit
that referenced
this pull request
Jul 21, 2026
) Semantic resolutions: - widget.py: keep this branch's _configure_transport (callback-gated view transport) and adopt #98's expanded append() style-channel signature; the transport hook now runs on the expanded message. - render_smoke_nonumpy.py: the probe string keeps this branch's xonly flag and gains #98's vstyle via baseWithStyle. - Bundles and example assets regenerated from the merged js/src (contains containment + style channels + context release); the plotly comparison baseline stays at main's exact bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A full-payload republish rebuilds the view (destroy + new ChartView, hence a new GL context), and browsers cap live contexts (~16 in Chrome). destroy() freed GPU resources but never released the context itself, so destroyed contexts lingered until GC and — under repeated republishes, e.g. an on_view_change-driven figure refresh — tripped the browser's "too many active WebGL contexts" eviction.
destroy() now releases the context via WEBGL_lose_context after freeing resources; the context-lost listeners are already removed and _destroyed is set, so the resulting event starts no recovery. Rebuild the committed static bundles and record the behavior in the dossier (§18) and renderer-architecture (R8).