Move density normalization into the shader#192
Closed
Alek99 wants to merge 1 commit into
Closed
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Greptile SummaryThis PR moves density normalization into the fragment shader and removes retained CPU density grids. The main changes are:
Confidence Score: 5/5This looks safe to merge. No blocking issues found in the changed code.
What T-Rex did
Important Files Changed
Reviews (1): Last reviewed commit: "Move density normalization into the shad..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
u_normScaleshader uniform instead of decoding, requantizing, allocating, and re-uploading the full grid every frameContext recovery rebuilds home from the canonical payload, then the existing view-request path refines the current window.
Verification
texImage2Dcallsruff check .: passedruff format --check .: 343 files already formattedtsc -p js/tsconfig.json --noEmit: passednode js/build.mjs --check: shipped bundles freshgit diff --check: passedLocal real-Chromium benchmark
500,000 source points, 824×488 density grid (402,112 cells), 120 exposure frames under SwiftShader:
Closes #166