ENG-10514: Update toolbar style - #198
Merged
Merged
Conversation
Greptile SummaryThis PR redesigns the chart toolbar and expands its interaction controls. The main changes are:
Confidence Score: 5/5This looks safe to merge. No blocking issues found in the changed code.
What T-Rex did
Important Files Changed
Reviews (8): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile |
Merging this PR will not alter performance
Comparing Footnotes
|
Alek99
self-requested a review
July 22, 2026 17:15
Alek99
requested changes
Jul 22, 2026
Alek99
left a comment
Member
There was a problem hiding this comment.
Needs to address the changes in slack
# Conflicts: # python/xy/static/index.js # python/xy/static/standalone.js
FarhanAliRaza
added a commit
that referenced
this pull request
Jul 27, 2026
…344) * Ship the Rust core with fat LTO and stripped symbols Whole-program LTO plus strip cuts the cdylib ~15% (1.51 -> 1.29 MB); the native scatter bench shows no runtime change beyond +/-15% run-to-run noise. .dynsym survives stripping, so ctypes binding is unaffected (abi_smoke passes 140/140 against the stripped build). panic stays unwinding because lib.rs catches panics at the C ABI; the wasm target keeps its explicit -C panic=abort in release.yml. Profile rationale and the not-adopted PGO lever are recorded in spec/design/rust-engine.md. * Keep wheel zoom and double-click reset alive under the box-zoom tool The dragMode guard added with the toolbar restyle (#198) blocked the plot wheel and dblclick handlers for every tool except pan, so activating the modebar Box Zoom tool killed cursor-anchored wheel zoom and double-click reset. Per the pan/zoom design spec (§5.5), the drag tool selects the drag gesture only; guard on the deliberate exception instead — 'none', the modebar escape hatch that releases page scroll for embedded charts. Records the contract in spec/api/interaction.md and spec/design/pan-and-zoom-configuration.md (whose 'none' + wheel_zoom example had drifted since #198), and adds a headless-Chromium regression probe covering both the box-zoom tool and the 'none' carve-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.