Fix gallery colormaps across renderers [mpl compatibility] - #245
Fix gallery colormaps across renderers [mpl compatibility]#245sselvakumaran wants to merge 5 commits into
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
|
<NEVERMIND, FIXED IN ANOTHER PR> second colormap (with blues and reds) is still empty. reds looks good. the second plot with just red does not have the gradient colormap legend like the first one and should be fixed. (note the matplotlib one has the legends looking different, one is smaller than the other!) |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What changed
Reds,bone,autumn, andBuPucolormaps_rlookup work across pyplot's colormap namespaceWhy
These are required by the in-scope Matplotlib 3.11 gallery examples. Before this change,
colorbar_basics.pystops before drawing itsReds_rimage because the colormap is absent.Official reference: https://matplotlib.org/stable/gallery/color/colorbar_basics.html
The after panel is intentionally a partial execution. It proves the
Reds_rregistry/rendering fix, then stops at the next independent compatibility gap:colorbar(location=..., anchor=..., shrink=...). A separate dependent PR handles those colorbar options.Gallery impact
misc/table_demo.pynow executes through its previous missing-BuPublocker, but its table layout is still not visually Matplotlib-compatible, so this PR does not claim it as visually complete.colorbar_basics.py,contourf_demo.py, andplot_streamplot.pyadvance to their next independent API blockers.Validation
570 passed, 65 skippedacross pyplot and SVG export suites