Reserve canvas room for categorical tick labels [mpl compatibility] - #256
Reserve canvas room for categorical tick labels [mpl compatibility]#256sselvakumaran wants to merge 3 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
|
legend is still cut off a bit on the left. |
What
Reserve enough left canvas space for authored and categorical y-axis tick labels instead of allowing long labels to be clipped by the export boundary.
This is intentionally stacked on #240 because that PR supplies the autoscale/default-margin foundation. I also rendered it together with #248 to verify the reported gallery case. #240 alone does not fix the clipped
Question 1–Question 6labels.Exact gallery comparison
Columns are Matplotlib 3.11 reference / current combined PR heads before this fix / #248 plus this fix.
The after image keeps every category label fully inside the canvas. The legend-border spacing is handled separately by #254.
Validation
PYTHONPATH=python /Users/srimans/dev/reviz/.venv/bin/python -m pytest tests/pyplot -qhorizontal_barchart_distribution.pyon the Fix line and legend gallery compatibility [mpl compatibility] #248 stack