Drop the lasso CodSpeed row - #267
Conversation
test_select_lasso_message_1m swings by tens of percent between runs on CodSpeed without any change to the selection path, so it reports noise rather than a regression signal. The remaining four selection rows still cover pick, both box-select paths, and the cross-filter row mask.
|
Warning Review limit reached
Next review available in: 9 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
What
test_select_lasso_message_1mis removed frombenchmarks/test_codspeed_selection.py.It reports noise, not signal. On #264 — a branch that touches only
_auto_cap_sizeand_zero_baseline_anchor, nowhere near the selection path — it moved 90.5 ms → 124.2 ms, a 27% swing attributable to nothing in the diff. A row that flags a regression on an unrelated change trains everyone to ignore the report.What still covers the selection handlers
The module keeps four rows: hover pick readout, zone-pruned box select, full-scan box select, and the cross-filter rows-to-shipped-mask encoding.
select_polygon's ray casting is the one gesture no longer trend-tracked in CodSpeed;bench_interaction.pystill measures the lasso end to end in the browser.Also updated
The removal touches everything that named the row or counted it: the
required_benchmarksguardrail intests/test_benchmark_environment.py, the untimedselect_polygonwarmup and the now-unusedLASSO_VERTICESconstant, and the module docstring,benchmarks/README.md,spec/benchmarks/results.md, andspec/benchmarks/methodology.md(selection module 5 → 4 rows, suite total 103 → 102).tests/test_benchmark_environment.py: 13 passed.ruff checkandruff format --checkclean.🤖 Generated with Claude Code