Skip to content

Drop the lasso CodSpeed row - #267

Merged
Alek99 merged 1 commit into
mainfrom
alek/drop-lasso-codspeed-row
Jul 24, 2026
Merged

Drop the lasso CodSpeed row#267
Alek99 merged 1 commit into
mainfrom
alek/drop-lasso-codspeed-row

Conversation

@Alek99

@Alek99 Alek99 commented Jul 24, 2026

Copy link
Copy Markdown
Member

What

test_select_lasso_message_1m is removed from benchmarks/test_codspeed_selection.py.

It reports noise, not signal. On #264 — a branch that touches only _auto_cap_size and _zero_baseline_anchor, nowhere near the selection path — it moved 90.5 ms → 124.2 ms, a 27% swing attributable to nothing in the diff. A row that flags a regression on an unrelated change trains everyone to ignore the report.

What still covers the selection handlers

The module keeps four rows: hover pick readout, zone-pruned box select, full-scan box select, and the cross-filter rows-to-shipped-mask encoding. select_polygon's ray casting is the one gesture no longer trend-tracked in CodSpeed; bench_interaction.py still measures the lasso end to end in the browser.

Also updated

The removal touches everything that named the row or counted it: the required_benchmarks guardrail in tests/test_benchmark_environment.py, the untimed select_polygon warmup and the now-unused LASSO_VERTICES constant, and the module docstring, benchmarks/README.md, spec/benchmarks/results.md, and spec/benchmarks/methodology.md (selection module 5 → 4 rows, suite total 103 → 102).

tests/test_benchmark_environment.py: 13 passed. ruff check and ruff format --check clean.

🤖 Generated with Claude Code

test_select_lasso_message_1m swings by tens of percent between runs on
CodSpeed without any change to the selection path, so it reports noise
rather than a regression signal. The remaining four selection rows still
cover pick, both box-select paths, and the cross-filter row mask.
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Alek99, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1fca34ee-3891-4ba5-8a1e-2fef048fbdbe

📥 Commits

Reviewing files that changed from the base of the PR and between fed5acc and 5a1494c.

📒 Files selected for processing (5)
  • benchmarks/README.md
  • benchmarks/test_codspeed_selection.py
  • spec/benchmarks/methodology.md
  • spec/benchmarks/results.md
  • tests/test_benchmark_environment.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch alek/drop-lasso-codspeed-row

Comment @coderabbitai help to get the list of available commands.

@codspeed-hq

codspeed-hq Bot commented Jul 24, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 102 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing alek/drop-lasso-codspeed-row (5a1494c) with main (fed5acc)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Alek99
Alek99 merged commit 595412d into main Jul 24, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant