-
Notifications
You must be signed in to change notification settings - Fork 46
perf: tail-only f32 re-encode on streaming append #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FarhanAliRaza
wants to merge
2
commits into
main
Choose a base branch
from
perf/tail-only-append-encode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -994,6 +994,13 @@ Rules that make the mode targets in §2 real: | |
| `resident_array_bytes` is built from the capacity total — equal to `canonical_bytes` | ||
| for any figure that never appended. Continuous channels already reported their own | ||
| growth buffers this way; columns now match. | ||
| Second corollary: every whole-column geometry ship keeps the encoded f32 result as | ||
| a per-column cache (`Column.encoded_f32`) so a streaming append re-encodes only the | ||
| appended tail (§5) — +4 B/point of resident RAM per shipped column (even when the | ||
| canonical column is memmapped), itemized per column and totaled as | ||
| `encode_cache_bytes`. It is a rebuildable derived cache under rule 1: any | ||
| offset/scale change or values rebinding drops it for a full re-encode into a fresh | ||
| buffer, never overwriting bytes a previously shipped split payload still borrows. | ||
|
Comment on lines
+997
to
+1003
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Document capacity-doubling costs accurately. The f32 cache has a minimum allocation and doubles on growth, so memory and CPU costs are amortized rather than fixed per current point/per tick.
📍 Affects 2 files
🤖 Prompt for AI AgentsSource: Coding guidelines |
||
| 5. **Canonical may be out-of-core (native `mmap`).** The "mmap (native)" cell in the | ||
| table above is realized: a canonical column may be backed by a disk `np.memmap` | ||
| instead of RAM. Because a memmap is a transparent `ndarray` — same dedup key, same | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
Keep cached geometry finite before it reaches the wire. The cache stores raw f32 output and the payload path ships it directly, allowing NaNs from canonical columns into vertex buffers.
python/xy/columns.py#L299-L305: encode invalid values using the established finite-value plus validity representation for full and tail cache updates.python/xy/_payload.py#L92-L100: use the cache only after it has equivalent validity semantics to the normal geometry encoder; otherwise retain the safe path.📍 Affects 2 files
python/xy/columns.py#L299-L305(this comment)python/xy/_payload.py#L92-L100🤖 Prompt for AI Agents
Source: Coding guidelines