Add dark mode benchmark image - #399
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
📝 WalkthroughWalkthroughBenchmark plotting now supports light and dark color schemes. Shared theme helpers configure the benchmark demo and generated charts. Documentation generates dark chart assets, and the README selects light or dark benchmark images based on display mode. ChangesDark-mode benchmark support
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant build
participant BenchmarkTheme
participant xy_line_chart
CLI->>build: pass selected color scheme
build->>BenchmarkTheme: select shared light or dark theme
BenchmarkTheme-->>build: return theme configuration
build->>xy_line_chart: generate themed benchmark charts
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Tip: cubic used a learning from your PR history. Let your coding agent read cubic learnings directly with the cubic MCP.
Fix all with cubic | Re-trigger cubic
Summary
<picture>element--color-scheme darksupport to the benchmark plot exporter and document the reproduction commandWhy
The README referenced only the light benchmark PNG, so it remained a bright white panel when GitHub was viewed in dark mode. The new source selection keeps the benchmark legible and visually consistent with the active color scheme.
Impact
GitHub automatically serves the dark benchmark image for dark-mode readers while retaining the existing light image as the fallback. Future dark assets can be regenerated from the benchmark source instead of being hand-edited.
Validation
uv run --with pre-commit pre-commit run --all-filesuv run ruff check .uv run ruff format --check .Summary by CodeRabbit
New Features
Documentation