Skip to content

feat: output suggestions in the order steps were defined#29

Merged
0xste merged 1 commit intomainfrom
aaronc/ordered-suggestions
Feb 13, 2024
Merged

feat: output suggestions in the order steps were defined#29
0xste merged 1 commit intomainfrom
aaronc/ordered-suggestions

Conversation

@aaronc
Copy link
Copy Markdown
Member

@aaronc aaronc commented Feb 12, 2024

When using gocuke with new feature files, I've found that it sometimes outputs step suggestions in an illogical order. This is because under the hood suggestions are stored in a map instead of an array. This PR creates converts that code to use an array so that suggestions get outputted in the same order as they were declared in the feature file.

Copy link
Copy Markdown
Collaborator

@0xste 0xste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@0xste 0xste merged commit 2968ddb into main Feb 13, 2024
@0xste 0xste deleted the aaronc/ordered-suggestions branch February 13, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants