Update documentation to support new 'autochangelog' setup.#103
Merged
mergify[bot] merged 1 commit intorelease-depot:masterfrom Oct 14, 2021
Merged
Update documentation to support new 'autochangelog' setup.#103mergify[bot] merged 1 commit intorelease-depot:masterfrom
mergify[bot] merged 1 commit intorelease-depot:masterfrom
Conversation
fuzzball81
previously approved these changes
Oct 14, 2021
d74fc41 to
7d32ce7
Compare
jpichon
reviewed
Oct 14, 2021
Contributor
jpichon
left a comment
There was a problem hiding this comment.
Sorry about the integration tests shenanigans. I think we also need to remove HISTORY.rst from setup.cfg (and replace it with the changelog if that's possible, not sure because of the mix of rst and md. Maybe just a link in the README to the RTD changelog instead?). I'm surprised the twine check doesn't catch this, since it was meant to help up catch README/HISTORY formatting issues before uploading to pypi.
Member
Author
|
Good catch, I thought I had removed the history file from there already. I'll look if there is a separate key we can use in setup.cfg for history/changelog, as the current setup will certainly not work. If not, I'll add a link as you suggest. |
2bd48d3 to
e68b309
Compare
* Removed unused HISTORY.rst * Updated stale AUTHORS.rst * Moved README from rst to md so we can include both in our long_description in setup.cfg Signed-off-by: Jason Guiditta <jguiditt@redhat.com>
e68b309 to
e099147
Compare
jpichon
approved these changes
Oct 14, 2021
fuzzball81
approved these changes
Oct 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Guiditta jguiditt@redhat.com