Add eager token construction option for faster connections#381
Draft
Monkatraz wants to merge 1 commit into
Draft
Add eager token construction option for faster connections#381Monkatraz wants to merge 1 commit into
Monkatraz wants to merge 1 commit into
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jackyzha0
approved these changes
Jun 1, 2026
| * awaited later even if that attempt is abandoned before the handshake is sent. | ||
| */ | ||
| type ConstructedHandshakeMetadata = | ||
| | { ok: true; metadata: unknown } |
Member
There was a problem hiding this comment.
we should know the metadata type here? also err should be narrowed probably
Monkatraz
force-pushed
the
brn-eager-token-construction
branch
from
7d583df to
4f74629
Compare
Monkatraz
force-pushed
the
brn-add-rehandshakes-via-expiry-fn
branch
from
327c7fe to
16f814c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What changed
Versioning