Skip to content

Fix attrs compatibility issue#143

Merged
JWCook merged 4 commits into
mainfrom
fix-attrs-compat
Dec 29, 2022
Merged

Fix attrs compatibility issue#143
JWCook merged 4 commits into
mainfrom
fix-attrs-compat

Conversation

@JWCook
Copy link
Copy Markdown
Member

@JWCook JWCook commented Dec 29, 2022

Fixes #140

  • Fix AttributeError when using a response cached with an older version of attrs
  • Update dependencies and pre-commit hooks
  • Update CI image and poetry versions
  • Fix implicit Optional type errors with latest mypy version

@JWCook JWCook added the bug Something isn't working label Dec 29, 2022
@JWCook JWCook added this to the v0.8 milestone Dec 29, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 29, 2022

Codecov Report

Merging #143 (b13a7e4) into main (73fbd39) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   95.22%   95.23%           
=======================================
  Files          11       11           
  Lines        1005     1007    +2     
  Branches      179      180    +1     
=======================================
+ Hits          957      959    +2     
  Misses         34       34           
  Partials       14       14           
Impacted Files Coverage Δ
aiohttp_client_cache/cache_control.py 98.24% <ø> (ø)
aiohttp_client_cache/session.py 90.47% <ø> (ø)
aiohttp_client_cache/backends/base.py 96.57% <100.00%> (+0.03%) ⬆️
aiohttp_client_cache/backends/redis.py 98.33% <100.00%> (ø)
aiohttp_client_cache/cache_keys.py 100.00% <100.00%> (ø)
aiohttp_client_cache/response.py 95.03% <100.00%> (ø)
aiohttp_client_cache/signatures.py 76.74% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JWCook JWCook changed the title Fix attrs compat Fix attrs compatibility issue Dec 29, 2022
@JWCook JWCook merged commit 659d284 into main Dec 29, 2022
@JWCook JWCook deleted the fix-attrs-compat branch December 29, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pickle transform is not stable between attrs releases

1 participant