Add `Capsules3D` archetype. by kpreid · Pull Request #7574 · rerun-io/rerun

kpreid · 2024-10-02T23:42:55Z

What

Part of Support for more 2D and 3D primitives #1361

Adds the archetype Capsules3D, component Length, and a matching visualizer.

Capsules are defined by their length and radius, and then transformed in the usual fashion to set their orientation. There is also a constructor for joining a pair of endpoints.

Missing parts that should make it into this PR before it leaves draft:

Needs an example image — I assume I don't have the permissions to upload one.

Further work not included in this PR, that will add complications:

C++ and Python have no from_endpoints constructors, because there wasn’t the quaternion math handy. Should we add an equivalent to glam::Quat::from_rotation_arc() to the minimal Rerun quaternion types?
There is no wireframe mesh support (expressed as having no FillMode component). This is because it was recommended that I use re_math’s capsules, but re_math has no support for generating wireframes. In the long run, we will want to support tapered capsules and cylinders and a new or substantially revised mesh generator to handle these cases will be needed anyway.
The support for setting the length of a capsule is a horrible kludge which is hard on the mesh cache — each length:radius ratio is cached separately. The idea I have for fixing this is adding “bone” support — the ability for selected vertices to be displaced by an externally controlled offset. This allows taking a single capsule mesh and stretching it without distorting the endcaps. (Tapered capsules will require multiple meshes to account for the angle at which the cone meets the endcap, but those can be fairly well approximated by a finite set of meshes.)

Checklist

I have read and agree to Contributor Guide and the Code of Conduct
I've included a screenshot or gif (if applicable)
I have tested the web demo (if applicable):
- Using examples from latest main build: rerun.io/viewer
- Using full set of examples from nightly build: rerun.io/viewer
The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
If applicable, add a new check to the release checklist!
If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

Neither extension has the `from_endpoints_and_radii` constructor that Rust does.

kpreid · 2024-10-07T04:28:19Z

OK, I think this is ready for review now. Things to note:

Someone needs to add an example image for the archetype docs — I assume I don't have the permissions to upload one myself.
There is no from_endpoints_and_radii() constructor in the C++ and Python Capsules3D archetypes yet, because there's no quaternion math function to compute the necessary rotation. Should I add such functions? If so, should I just translate glam's code that does the job, or do something else (possibly for licensing considerations)?
The CI check "Check if running codegen would produce any changes" is failing, but pixi run codegen --force locally doesn't change anything.

crates/store/re_types/src/components/length_ext.rs

emilk

Looks good, but before we commit to length=Z we should really look into what is the standard (if any)

Cargo.toml

emilk · 2024-10-07T14:09:23Z

crates/store/re_types/definitions/rerun/archetypes/capsules3d.fbs

+/// 3D capsules; cylinders with hemispherical caps.
+///
+/// Capsules are defined by two endpoints (the centers of their end cap spheres), which are located
+/// at (0, 0, 0) and (0, 0, length), that is, extending along the positive direction of the Z axis.


Did you check what other libraries use as their "length" axis? See #1361 (comment)

I'm especially interested in what is commonly used in the ROS ecosystem

I did some web searching and couldn’t easily find any ROS-related things that had actually implemented and documented capsules to compare. While I was looking I found a couple unrelated things that used Z or the two-points representation. But I am absolutely terrible at thorough research and wouldn’t know where to start with reliably determining what “other visualization tools” tend to use.

We've decided to make this configurable in a follow-up PR: #1361 (comment)

crates/store/re_types/definitions/rerun/archetypes/capsules3d.fbs

emilk · 2024-10-07T14:15:24Z

crates/store/re_types/src/archetypes/capsules3d_ext.rs

+                let length = direction.length();
+                let quaternion = glam::Quat::from_rotation_arc(glam::Vec3::Z, direction / length);


We should explicitly handle length = 0 here, preferably with a test too

crates/viewer/re_space_view_spatial/src/proc_mesh.rs

crates/viewer/re_space_view_spatial/src/visualizers/utilities/entity_iterator.rs

emilk · 2024-10-07T15:00:23Z

rerun_cpp/src/rerun/archetypes/capsules3d_ext.cpp

+        /* TODO(kpreid): This should exist for parity with Rust, but actually implementing this
+           needs a bit of quaternion math.
+
+        /// Creates a new `Capsules3D` where each capsule extends between the given pairs of points.
+        //
+        // TODO(andreas): This should not take an std::vector.
+        //
+        static Capsules3D from_endpoints_and_radii(
+            const std::vector<datatypes::Vec3D>& start_points,
+            const std::vector<datatypes::Vec3D>& end_points,
+            const std::vector<float>& radii
+        );
+        */


It would be nice if we could just call into Rust to do it for us, but adding FFI functions is tedious and error prone.

This could possibly help:

Convert components to arrow early in all log APIs #7620

For now I'm fine with C++ missing the feature at the start

Implementing from_endpoints_and_radii anywhere will be easy once we have a MainAxis component, as suggested in #1361 (comment)

jeongseok-meta · 2024-10-22T21:59:20Z

Thank you for adding this feature. Can't wait for the tapered capsules support!

emilk · 2024-10-28T15:13:42Z

crates/store/re_types/src/archetypes/capsules3d_ext.rs

+                let length = direction.length();
+
+                let quaternion = if length > 0.0 {


this is more robust against small non-zero lengths (e.g. denormals):

Suggested change

let length = direction.length();

let quaternion = if length > 0.0 {

let direction = direction.normalize_or_zero();

let quaternion = if direction != glam::Vec3::ZERO {

kpreid added 3 commits September 30, 2024 17:38

Profile scopes for proc mesh generation.

fbe2064

Use ordered-float ≥4.2.2 with a better Debug implementation.

866ed4b

Add Capsules3D archetype.

55f8e36

kpreid added 📺 re_viewer affects re_viewer itself include in changelog labels Oct 2, 2024

kpreid added 2 commits October 6, 2024 21:12

Add C++ and Python extensions; fix various nits.

7b327df

Neither extension has the `from_endpoints_and_radii` constructor that Rust does.

Fixes from CI lints.

b5e5758

kpreid marked this pull request as ready for review October 7, 2024 04:28

abey79 reviewed Oct 7, 2024

View reviewed changes

crates/store/re_types/src/components/length_ext.rs Show resolved Hide resolved

emilk self-requested a review October 7, 2024 14:06

emilk approved these changes Oct 7, 2024

View reviewed changes

kpreid added 2 commits October 10, 2024 17:15

From review: plurals, dep version, handle zero length, default 1.0.

69592c6

Use proper error for unsupported wireframes.

8b6ded3

kpreid requested a review from emilk October 11, 2024 00:18

teh-cmc mentioned this pull request Oct 19, 2024

Post-release self-triage: 0.19 edition #7638

Closed

1 task

emilk approved these changes Oct 28, 2024

View reviewed changes

emilk added this to the 0.20 - H.264, Undo milestone Oct 28, 2024

emilk added 5 commits October 28, 2024 16:20

Merge branch 'main' into capsule

6630033

Code cleanup

917cf77

Merge branch 'main' into capsule

5774862

Add example and screenshot

fdc9cae

Opt-out of comparison-test

2d1e7f0

emilk merged commit 6599f87 into rerun-io:main Oct 29, 2024

emilk added the 🪵 Log & send APIs Affects the user-facing API for all languages label Nov 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `Capsules3D` archetype.#7574

Add `Capsules3D` archetype.#7574
emilk merged 12 commits intorerun-io:mainfrom
kpreid:capsule

kpreid commented Oct 2, 2024 •

edited by emilk

Loading

Uh oh!

kpreid commented Oct 7, 2024

Uh oh!

Uh oh!

emilk left a comment

Uh oh!

Uh oh!

emilk Oct 7, 2024

Uh oh!

kpreid Oct 10, 2024

Uh oh!

emilk Oct 28, 2024

Uh oh!

Uh oh!

emilk Oct 7, 2024

Uh oh!

Uh oh!

Uh oh!

emilk Oct 7, 2024

Uh oh!

emilk Oct 28, 2024

Uh oh!

jeongseok-meta commented Oct 22, 2024

Uh oh!

emilk Oct 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		let length = direction.length();
		let quaternion = glam::Quat::from_rotation_arc(glam::Vec3::Z, direction / length);

		let length = direction.length();

		let quaternion = if length > 0.0 {

Conversation

kpreid commented Oct 2, 2024 • edited by emilk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Checklist

Uh oh!

kpreid commented Oct 7, 2024

Uh oh!

Uh oh!

emilk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

emilk Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

kpreid Oct 10, 2024

Choose a reason for hiding this comment

Uh oh!

emilk Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

emilk Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

emilk Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

emilk Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

jeongseok-meta commented Oct 22, 2024

Uh oh!

emilk Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kpreid commented Oct 2, 2024 •

edited by emilk

Loading