Allow passing seconds/nanoseconds to VideoFrameReference archetype#7833
Merged
Allow passing seconds/nanoseconds to VideoFrameReference archetype#7833
VideoFrameReference archetype#7833Conversation
abey79
approved these changes
Oct 21, 2024
rerun_py/rerun_sdk/rerun/archetypes/video_frame_reference_ext.py
Outdated
Show resolved
Hide resolved
Wumpf
force-pushed
the
andreas/improve-video-frame-reference-api
branch
from
be221c2 to
c6bc61e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
seconds=#7822Also, passing a float directly will trigger a warning now.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.