Skip to content

Finish dataframe reference page#7865

Merged
teh-cmc merged 4 commits intomainfrom
cmc/dataframe_doc_final
Oct 23, 2024
Merged

Finish dataframe reference page#7865
teh-cmc merged 4 commits intomainfrom
cmc/dataframe_doc_final

Conversation

@teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 22, 2024

We were missing a bunch of features and assets to be able to finish this, but now we have it all.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 📖 documentation Improvements or additions to documentation include in changelog feat-dataframe-api Everything related to the dataframe API do-not-merge Do not merge this PR labels Oct 22, 2024
@github-actions
Copy link

github-actions bot commented Oct 22, 2024

Deployed docs

Commit Link
49de119 https://landing-5vq4hyi0o-rerun.vercel.app/docs

@teh-cmc teh-cmc mentioned this pull request Oct 22, 2024
1 task
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ❤️

Should this be included in 0.19.1?

Base automatically changed from cmc/log_file_at to main October 23, 2024 07:08
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 23, 2024

Should this be included in 0.19.1?

Yeah, for sure. If we don't release from main, I'll probably just copy the docs/ directory in its entirety to the 0.19.1 branch just to be sure.

@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Oct 23, 2024
@teh-cmc teh-cmc force-pushed the cmc/dataframe_doc_final branch from 006ebf5 to 38cb987 Compare October 23, 2024 07:12
@teh-cmc teh-cmc merged commit 3eb08b7 into main Oct 23, 2024
@teh-cmc teh-cmc deleted the cmc/dataframe_doc_final branch October 23, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📖 documentation Improvements or additions to documentation feat-dataframe-api Everything related to the dataframe API include in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants