Update the python package to support python 3.13, update C++ arrow to 18.0.0#7930
Merged
Update the python package to support python 3.13, update C++ arrow to 18.0.0#7930
Conversation
jleibs
changed the title
jleibs
added
sdk-python
Deployed docs
|
Member
Author
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/11578055123 |
Wumpf
requested changes
Oct 29, 2024
pixi.toml
Outdated
| ] } | ||
| cpp-clean = "rm -rf build CMakeCache.txt CMakeFiles" | ||
| cpp-build-tests = { cmd = "cmake --build build/debug --config Debug --target rerun_sdk_tests", depends_on = [ | ||
| cpp-build-tests = { cmd = "cmake --build build/debug --config Release --target rerun_sdk_tests", depends_on = [ |
Member
Author
There was a problem hiding this comment.
Oops, that was an accident -- I was curious if Release vs Debug might influence the symbols exposed to the linker when I was running tests.
Wumpf
changed the title
Wumpf
approved these changes
Oct 29, 2024
Member
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
clean build (pixi run cpp-clean) fixed it!
hgaiser
reviewed
Oct 30, 2024
| keywords = ["computer-vision", "logging", "rerun"] | ||
| name = "rerun-sdk" | ||
| requires-python = ">=3.8, <3.13" | ||
| requires-python = ">=3.8, <3.14" |
There was a problem hiding this comment.
Can we change this to:
Suggested change
| requires-python = ">=3.8, <3.14" | |
| requires-python = ">=3.8" |
As I explain here, this is often preferred.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Also bumps our pixi arrow version to 18 since this is required for python 3.13 and I want it to get tested.
Bump our C++ arrow library to match.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.