Expose additional information about decoded frames in the viewer#7932
Merged
Expose additional information about decoded frames in the viewer#7932
Conversation
…o can be passe through the viewer now!
Wumpf
added
📺 re_viewer
emilk
approved these changes
Oct 30, 2024
| time_range: _, // TODO(emilk): maybe add to `PickableTexturedRect` and `PickingHitType::TexturedRect` so we can show on hover? | ||
| is_pending, | ||
| show_spinner, | ||
| frame_info: _, // TODO(emilk): maybe add to `PickableTexturedRect` and `PickingHitType::TexturedRect` so we can show on hover? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Minimized by default.
Originally, I wanted to add some more information from the get-go like i/idr/p/b-frame type but turns out we don't really have all that much information around today for sure - a big part of this is that typically just pass in chunks to decoder and get 0-1 frames out for each chunk (my current understand is that it could be 0-n, but n>1 typically doesn't make sense because a single mp4 sample has a single timestamp!). Meaning we typically don't maintain the chunk/frame relationship.
However, this adjusted structure should make it easy to expose optional fields on
FrameInfoto forward all sort of thingsChecklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.