Consistent open/import/log_file behaviors in all common scenarios#7966
Merged
Consistent open/import/log_file behaviors in all common scenarios#7966
Conversation
9547131 to
7bd6667
Compare
9d199eb to
b614e00
Compare
26e6233 to
1f4c61a
Compare
1f4c61a to
c314a60
Compare
Member
Author
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/11690170174 |
emilk
approved these changes
Nov 6, 2024
Member
emilk
left a comment
There was a problem hiding this comment.
Well, that was indeed painful and complicated, but I see no obvious better way. 👍
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the major data-loading paths now behave sanely and consistently on both native and web.
You can try and look at the matrix below for the specific behavior of each path, but really my advice would be to just play with it to get a sense of things.
One of these days we'll clearly need a bottom-up in-hindsight refactoring for all these things, it is so complex.
But today is not that day.
Checklist:
log_file:Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.