Fix playback of HDR AV1 videos in native viewer

[emilk]

What

• Closes Video opened through rerun looks distorted and has wrong colors #7973
• Part of Support HDR video (shows wrong color or glitches today) #7594

Review with ignoring whitespace changes

Before

After

VLC (for reference)

Checklist

• I have read and agree to Contributor Guide and the Code of Conduct
• I've included a screenshot or gif (if applicable)
• I have tested the web demo (if applicable):
  • Using examples from latest main build: rerun.io/viewer
  • Using full set of examples from nightly build: rerun.io/viewer
• The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
• If applicable, add a new check to the release checklist!
• If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

• PR Build Summary
• Recent benchmark results
• Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

[Wumpf]

nice! I trust there's still a separate warning about Bt.2020 interpretation and friends?
After all the problem with typical HDR content is twofold:

• bit depth - partially better addressed here
• color space conversion

[Wumpf]

oh interesting, the video in the issue is unplayable by Firefox. It has 10bit Bt.709 YUV 4:2:0
So indeed really the only thing we don't support here is the 10bits. Fascinating, didn't know that's a thing!

[emilk]

Btw @Wumpf we are missing a check that the number of bytes in the frame matches the given dimensions and pixel format. A debug-assert and/or warning in re_renderer would be very helpful

[Wumpf]

👍 good find, we should definitely add that

[emilk]

Actually, we do have a check here that triggers as it should:

rerun/crates/viewer/re_renderer/src/resource_managers/image_data_to_texture.rs

Lines 183 to 190 in 325fc41

	// TODO(andreas): Nv12 needs height divisible by 2?
	if data.len() != expected_num_bytes {
	return Err(ImageDataToTextureError::InvalidDataLength {
	label: label.clone(),
	expected: expected_num_bytes,
	actual: data.len(),
	});
	}

My bad!

[emilk]

Why does rerun_js fail?? O.o

• Caused by Fix wasm-bindgen patch #7970 ?
• Fixed by Better dev experience for JS generated file hashes #7975 ?

Trying if rebasing on an earlier commit works…