Skip to content

Document arrow datatypes#7986

Merged
emilk merged 8 commits intomainfrom
emilk/document-arrow-datatype
Nov 4, 2024
Merged

Document arrow datatypes#7986
emilk merged 8 commits intomainfrom
emilk/document-arrow-datatype

Conversation

@emilk
Copy link
Member

@emilk emilk commented Nov 4, 2024

What

Example output: https://github.com/rerun-io/rerun/blob/emilk/document-arrow-datatype/docs/content/reference/types/datatypes/image_format.md

The format of the arrow datatypes is far from perfect, but it is intelligible and explicit, so I think it is good enough for now.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 📖 documentation Improvements or additions to documentation include in changelog labels Nov 4, 2024
@github-actions
Copy link

github-actions bot commented Nov 4, 2024

Deployed docs

Commit Link
7fe8240 https://landing-lvm3e63gk-rerun.vercel.app/docs

@emilk emilk marked this pull request as ready for review November 4, 2024 12:29
//! Document an Arrow datatype as human-readable markdown.
//!
//! Note that we use the `arrow` library in this module,
//! with just a thin `arrow2` wrapper around it.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to make it easier to migrate away from arrow2

@emilk emilk changed the title Document arrow datatype Document arrow datatypes Nov 4, 2024
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@emilk emilk merged commit d1d2db2 into main Nov 4, 2024
@emilk emilk deleted the emilk/document-arrow-datatype branch November 4, 2024 19:45
emilk added a commit that referenced this pull request Nov 5, 2024
### What
* Follow-up to #7986

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7996?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7996?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7996)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📖 documentation Improvements or additions to documentation include in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document/publish our arrow schemas

2 participants