Skip to content

Check rerun notebook version on first import#8030

Merged
jprochazk merged 4 commits intomainfrom
jan/check-notebook-version-mismatch
Nov 12, 2024
Merged

Check rerun notebook version on first import#8030
jprochazk merged 4 commits intomainfrom
jan/check-notebook-version-mismatch

Conversation

@jprochazk
Copy link
Member

@jprochazk jprochazk commented Nov 7, 2024

What

Side note: Should this close the above issue? We said we'd prefer to express version requirements in the context of pip instead of a warning

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jprochazk jprochazk added notebook Jupyter notebooks etc include in changelog sdk-python Python logging API labels Nov 7, 2024
@jprochazk
Copy link
Member Author

jprochazk commented Nov 7, 2024

Tested by installing rerun-notebook, then updating crate versions to 0.21.0-alpha.1 and installing rerun-sdk:

image

I tried using the warnings module for this, but I don't really understand how it works. I had to set a filter to actually see the warning, which seems bad? Should this just be a print instead?

@jprochazk jprochazk requested a review from jleibs November 7, 2024 11:54
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jprochazk jprochazk merged commit 0ca396a into main Nov 12, 2024
@jprochazk jprochazk deleted the jan/check-notebook-version-mismatch branch November 12, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

include in changelog notebook Jupyter notebooks etc sdk-python Python logging API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants