This repository was archived by the owner on Apr 24, 2021. It is now read-only.
Fix wrong types for nested record fields#47
Closed
amiralies wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Before: After: |
amiralies
changed the title
Contributor
|
Thanks a lot for this. |
Contributor
Author
|
Yeah I think the same in fact typescript language server and merlin/ocamllsp have similar behaviour. |
cristianoc
added a commit
that referenced
this pull request
Jan 4, 2021
Fixes rescript-lang/rescript-vscode#52 Continuation of #47 Show the correct type information, including type definition for record fields. Also, fix issue in the docstring shown. Before it was either misssing (entire record type) or wrong (for record field, it was showing the doc comment of the containing record type). Clean up code in References.
Contributor
|
Continued this in a more extensive PR: #48. |
cristianoc
added a commit
that referenced
this pull request
Jan 4, 2021
Fixes rescript-lang/rescript-vscode#52 Continuation of #47 Show the correct type information, including type definition for record fields. Also, fix issue in the docstring shown. Before it was either misssing (entire record type) or wrong (for record field, it was showing the doc comment of the containing record type). Clean up code in References.
chenglou
pushed a commit
to chenglou/rescript-editor-support
that referenced
this pull request
Apr 24, 2021
Fixes rescript-lang/rescript-vscode#52 Continuation of rescript-lang#47 Show the correct type information, including type definition for record fields. Also, fix issue in the docstring shown. Before it was either misssing (entire record type) or wrong (for record field, it was showing the doc comment of the containing record type). Clean up code in References.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a temporarily fix for rescript-lang/rescript-vscode#52