add syntax for string interpolation

[amiralies]

something like rescript-lang/vim-rescript#44

[cristianoc]

Is this about syntax highlighting?

[amiralies]

Yes

…

On Tue, Jun 22, 2021, 7:54 AM Cristiano Calcagno ***@***.***> wrote: Is this about syntax highlighting? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#275 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADFFSICOSPHWVTO5FNUIO23TT7655ANCNFSM46XRCQFA> .

[zth]

@amiralies is this still relevant, or was this fixed by the recent changes to highlighting?

[amiralies]

I'm not sure, as I vscode is not my main editor.

I think these cases should be covered.

let var = `hello ${name} how you doin?`

let var2 = j`hello ${name} how you doin?`

let var3 = j`hello $name how you doin?`

let varInvalid = `hello $name how you doin?`

let expr = `2 + 2 is ${Int.toString(2 + 2)}`

[zth]

Right. Well, at least on my theme, it's not fully highlighted:

[amiralies]

This is current vim behavior.

looks like var3 and expr case should be addressed, this might be tricky to implement in textmate grammars tho .

[zth]

This is very close to being fixed in the semantic highlighting PR:

Will see if we can fix the $name case there too, so we can close this.