feat(root): refactor root access

[researchxxl]

step 1 restore outdated and buggy old root code
step 2 use a maintained libsuperuser dependency instead of the old unmaintained one

[vale981]

Currently running the debug build :). Can confirm that this works. Thanks :)

[vale981]

Currently the "Run Script" feature does not work as the scripts ion ".stfolder" are likely not accessible due to permission issues. Would it be possible to fix this?

[researchxxl]

@vale981

Currently the "Run Script" feature does not work as the scripts ion ".stfolder" are likely not accessible due to permission issues. Would it be possible to fix this?

pls look at util.runScriptSet and runShellCommandGetOutput(command, false).. if you set true you will get root exec of the scripts

needs secure and proper implementation tbh for being accepted here and file permissions should be checked before

[researchxxl]

@dbhavsar76 may i kindly ask if you like to have fun with this?? it is also ok for me if you dont take the challenge

[dbhavsar76]

I'll see what i can do. No promises. Meanwhile, I have the drawer ready.

[researchxxl]

we don't want to use the deprecated libsuperuser library, right? I'm checking out shizuku first, if it's not helpful then there is libsu from topjohnwu.

Edit: libsu will be better for our use case, i think.

Also will this not create problem with play store?

we first need your help to migrate the settings screen regarding root options because that has conflicts with main.. libsu should be okey.. we never know if google play might block a spec lib from some day on at least they didnt block the old lib

@nel0x wrote some weeks ago they like to help with the root implementation.. but from my pov they didnt find time yet and we are not in a hurry :)) you could ping them

[dbhavsar76]

What else needs to be done here?

[researchxxl]

What else needs to be done here?

@dbhavsar76
imo this might be reasonable

• use a maintained libsuperuser dependency instead of the old unmaintained one
• fix script runner after sync
• show a graceful error message if root permissions are revoke
• optional move all root related code to separate class so we can add a build variant later if google play forbidds root in future policy updates