Mongo range queries: setup and KVTable implementations#251
Closed
ableegoldman wants to merge 2 commits intomainfrom
Closed
Mongo range queries: setup and KVTable implementations#251ableegoldman wants to merge 2 commits intomainfrom
ableegoldman wants to merge 2 commits intomainfrom
Conversation
agavra
reviewed
Feb 27, 2024
| final Admin admin, | ||
| final CollectionCreationOptions collectionCreationOptions | ||
| ) { | ||
| final int numPartitions = numPartitionsForKafkaTopic(admin, changelogTopicName); |
Contributor
There was a problem hiding this comment.
piping the changelog topic name and the admin all the way down here just to get the number of partitions (which is then used to build a partitioner) seems to be leaking a lot of unnecessary information
instead I suggest that we put the partitioner itself in the RemoteTableSpec interface and pass the partitioner directly into this
FWIW this is also closer to your TODO which allows use for a custom partitioner.
Contributor
Author
|
closing this since it was implemented in #347 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the basic setup for our approach to range queries via client-side filtering based on a partitioner, as well as the implementation for KV stores. The window range queries are in a separate PR since they're a bit more involved.