Conversation
82453f6 to
d97aabd
Compare
- adds tls support for the rs3 connection - adds a metric that records the average get latency. This is done via a wrapper to the RS3 client so we can add more metrics easily later on. - the rs3 protocol was updated to pass the pss/store id in headers, so we need to generate specific stubs for each pss (stubs are very cheap to create, and they all share a grpc channel). As such, the channel is moved into RemotePssStubsProvider, which now owns the channel and creates stubs for a given pss. When creating a stub, it adds an interceptor that adds the right headers for a given pss
d97aabd to
bee1748
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some rs3 changes to get it going on the soak workload: