Merged
Conversation
Adds the smoke test app from sindri to the public repo under a new module kafka-client-examples::simple-example. Adds steps to the PR builder to run smoke tests
rodesai
force-pushed
the
add-system-test-app
branch
from
ec6fcea to
f69e240
Compare
agavra
approved these changes
Aug 1, 2023
Comment on lines
+11
to
+12
| // todo: how to set the version here? | ||
| implementation(project(":kafka-client")) |
Contributor
There was a problem hiding this comment.
I think the only way to do this would be to depend on published artifacts (e.g. "implementation("dev.responsive...:kafka-client:<version>"))
Contributor
Author
There was a problem hiding this comment.
This is not an issue anymore. Just forgot to cleanup the comment. Getting the client version built in the same build is what we want.
| implementation("com.scylladb:java-driver-mapper-runtime:4.15.0.0") | ||
| } | ||
|
|
||
| java { |
Contributor
There was a problem hiding this comment.
can we just keep the entire responsive-pub at JDK 11? I think it'd make it simpler to develop in IDEs
rodesai
force-pushed
the
add-system-test-app
branch
from
27a794c to
bf14b24
Compare
ableegoldman
reviewed
Aug 1, 2023
| try (final Admin admin = Admin.create(config.originals())) { | ||
| final String source = config.getSourceTopic(); | ||
| for (final var topic : List.of(source, source + "-out", source + "-counts")) { | ||
| LOGGER.info("create topic {}", topic); |
Contributor
Author
There was a problem hiding this comment.
whoops - I was signed in as the tools user
rodesai
force-pushed
the
add-system-test-app
branch
from
88adc4a to
7223996
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the smoke test app from sindri to the public repo
under a new module kafka-client-examples::simple-example.
Adds steps to the PR builder to run smoke tests