RestRequest.JsonSerializer = new JsonCustomSerializer<T>() not working

[andrewkip]

Hello!

It seems that in new version RestSharp 106.6.3.0 ovveriding JSon Serializer in RestRequest.JsonSerializer not working
for example:
var request = new RestRequest
{
Method = Method.POST,
RequestFormat = DataFormat.Json,
JsonSerializer = new JsonCustomSerializer()
};

request.AddJsonBody(obj);

but JsonCustomSerializer.Serialize not calling...
and ContentType of Body not equal to JsonCustomSerializer.ContentType

have to do dirty Hack:
request.AddJsonBody( request.JsonSerializer.Serialize(obj));

[alexeyzimarev]

The Serialize method is not called when you use AddJsonBody but when you execute the request. Are you sure that your serializer is never called?

[andrewkip]

I've checked again Serialize method is not calling when I execute request too.

By the way. If you say that Serialize is called when request executes How can accompliesh following scenario:

I've serialized by DataContractJsonSerializer (System.Runtime.Serialization.Json;) class Class1 with property Prop1 with alternative name for serialization prop_1 (see below]).
How to put this properly named (with prop_1) serialized object into the body? If I addJsonBody it serialized as object with Prop1?

[DataContract]
public class Class1
{
[DataMember(Name = "prop_1")]
public string Prop1 { get; set; }
}

[alexeyzimarev]

I am not sure what you mean. How the moment when your body object is serialized affect the serialization outcome?

[alexeyzimarev]

Fixed in 106.6.4

[andrewkip]

Still not working.
I need Class1 serialized into the request body (as I can see in AddJsonBiody method) in proper way, so I create custom serializer and adjust custom serializer to RestRequest JsonSerializer, but when I call AddJsonBody(obj) Serialize mthod of custom serializer is not called.
How ever the summary from RestRequest.cs concerning RestRequest.JsonSrializer sounds like this method must be called - correct me if I wrong.

Here is the summary:
///

/// Serializer to use when writing JSON request bodies. Used if RequestFormat is Json.
/// By default the included JsonSerializer is used (currently using JSON.NET default serialization).
///

public ISerializer JsonSerializer { get; set; }

[andrewkip]

I've found the problem:

I've defined ContentType in my Custom serializer as application/json but

in RestSharp\RestRequestExtensions.cs
in internal static class RestRequestExtensions
at line 22

var requestSerializer = serializers.FirstOrDefault(x => x != null && x.ContentType == body.ContentType);

body.ContentType is null but x.ContentType is application/json

so if I define ContentType as null in my serializer evrething works fine.

Where do I have to define body ContentType?
Or should I define in custom serializer ContentType as null?

[alexeyzimarev]

Cool, thank you for helping me finding the issue. I need to take into account the request content type. Maybe to set the parameter content type to the request content type if it is set.

[alexeyzimarev]

Let me add some tests for it. The client serializer in your case works as expected, but the request-level serializer should supersede it.

[e-tobi]

Just stumbled upon the same issue. My workaround was to use restClient.UseSerializer() with a custom implementation of IRestSerializer for Newtonsoft.Json:

public class NewtonsoftJsonRestSerializer : IRestSerializer
{
    private readonly JsonSerializer _serializer;

    public NewtonsoftJsonRestSerializer()
    {
        _serializer = new JsonSerializer
        {
            MissingMemberHandling = MissingMemberHandling.Ignore,
            NullValueHandling = NullValueHandling.Include,
            DefaultValueHandling = DefaultValueHandling.Include
        };
    }

    public string Serialize(object obj)
    {
        using (var stringWriter = new StringWriter())
        {
            using (var jsonTextWriter = new JsonTextWriter(stringWriter))
            {
                _serializer.Serialize(jsonTextWriter, obj);

                return stringWriter.ToString();
            }
        }
    }

    public string ContentType { get; set; } = "application/json";

    public T Deserialize<T>(IRestResponse response)
    {
        var content = response.Content;

        using (var stringReader = new StringReader(content))
        {
            using (var jsonTextReader = new JsonTextReader(stringReader))
            {
                return _serializer.Deserialize<T>(jsonTextReader);
            }
        }
    }

    public string Serialize(Parameter parameter) => Serialize(parameter.Value);

    public string[] SupportedContentTypes { get; } =
    {
        "application/json", "text/json", "text/x-json", "text/javascript", "*+json"
    };

    public DataFormat DataFormat { get; } = DataFormat.Json;
}

[tomgallard]

We are having this issue too. Please reopen this issue, as it has caused breaking changes to existing implementations, and is not fixed as of 106.6.5

[andrewkip]

Let me add some tests for it. The client serializer in your case works as expected, but the request-level serializer should supersede it.

As I can see - yes.

[vmalinovskiy]

The same for me. Do you plan to fix this?